From 4953fbcd9e114df4179fee4ef3e2f546bbd1605c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?ljx=E6=9D=8E=E9=9D=99=E9=9B=AA?= Date: Thu, 21 Apr 2022 19:50:18 +0800 Subject: [PATCH] if workload is not found, skip to ensure work Signed-off-by: jingxueli --- pkg/controllers/binding/binding_controller.go | 3 +++ pkg/controllers/binding/cluster_resource_binding_controller.go | 3 +++ 2 files changed, 6 insertions(+) diff --git a/pkg/controllers/binding/binding_controller.go b/pkg/controllers/binding/binding_controller.go index e92a7acf9..2ff1fea71 100644 --- a/pkg/controllers/binding/binding_controller.go +++ b/pkg/controllers/binding/binding_controller.go @@ -115,6 +115,9 @@ func (c *ResourceBindingController) syncBinding(binding *workv1alpha2.ResourceBi workload, err := helper.FetchWorkload(c.DynamicClient, c.InformerManager, c.RESTMapper, binding.Spec.Resource) if err != nil { + if apierrors.IsNotFound(err) { + return controllerruntime.Result{}, nil + } klog.Errorf("Failed to fetch workload for resourceBinding(%s/%s). Error: %v.", binding.GetNamespace(), binding.GetName(), err) return controllerruntime.Result{Requeue: true}, err diff --git a/pkg/controllers/binding/cluster_resource_binding_controller.go b/pkg/controllers/binding/cluster_resource_binding_controller.go index 5ba49b39e..163b9cc5a 100644 --- a/pkg/controllers/binding/cluster_resource_binding_controller.go +++ b/pkg/controllers/binding/cluster_resource_binding_controller.go @@ -108,6 +108,9 @@ func (c *ClusterResourceBindingController) syncBinding(binding *workv1alpha2.Clu workload, err := helper.FetchWorkload(c.DynamicClient, c.InformerManager, c.RESTMapper, binding.Spec.Resource) if err != nil { + if apierrors.IsNotFound(err) { + return controllerruntime.Result{}, nil + } klog.Errorf("Failed to fetch workload for clusterResourceBinding(%s). Error: %v.", binding.GetName(), err) return controllerruntime.Result{Requeue: true}, err }