karmada-io
/
karmada
mirror of https://github.com/karmada-io/karmada.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2158 from RainbowMango/pr_update_misleading_comments 

Fixed misleading or outdate comments about --cluster-namespace flag
This commit is contained in:
karmada-bot 2022-07-10 14:50:34 +08:00 committed by GitHub
parent 821a18542e f5eeaf6dd3
commit 65cec65513
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/karmadactl/get.go
View File

@ -105,7 +105,7 @@ type CommandGetOptions struct {
// global flags // global flags
options.GlobalCommandOptions options.GlobalCommandOptions
// ClusterNamespace holds the namespace name where the member cluster objects are stored. // ClusterNamespace holds the namespace name where the member cluster secrets are stored.
ClusterNamespace string ClusterNamespace string
Clusters []string Clusters []string
@ -608,7 +608,7 @@ func (g *CommandGetOptions) watch(watchObjs []WatchObj) error {
return nil return nil
} }
//watchMultiClusterObj watch objects in multi clusters by goroutines // watchMultiClusterObj watch objects in multi clusters by goroutines
func (g *CommandGetOptions) watchMultiClusterObj(watchObjs []WatchObj, mapping *meta.RESTMapping, outputObjects *bool, printer printers.ResourcePrinterFunc) { func (g *CommandGetOptions) watchMultiClusterObj(watchObjs []WatchObj, mapping *meta.RESTMapping, outputObjects *bool, printer printers.ResourcePrinterFunc) {
var wg sync.WaitGroup var wg sync.WaitGroup

2
pkg/karmadactl/join.go
View File

@ -64,7 +64,7 @@ func joinExample(parentCommand string) string {
type CommandJoinOption struct { type CommandJoinOption struct {
options.GlobalCommandOptions options.GlobalCommandOptions
// ClusterNamespace holds the namespace name where the member cluster objects are stored. // ClusterNamespace holds the namespace name where the member cluster secrets are stored.
ClusterNamespace string ClusterNamespace string
// ClusterName is the cluster's name that we are going to join with. // ClusterName is the cluster's name that we are going to join with.

2
pkg/karmadactl/options/global.go
View File

@ -6,7 +6,7 @@ import (
"github.com/spf13/pflag" "github.com/spf13/pflag"
) )
//DefaultKarmadaClusterNamespace defines the default namespace where the member cluster secrets are stored. // DefaultKarmadaClusterNamespace defines the default namespace where the member cluster secrets are stored.
const DefaultKarmadaClusterNamespace = "karmada-cluster" const DefaultKarmadaClusterNamespace = "karmada-cluster"
// DefaultKarmadactlCommandDuration defines the default timeout for karmadactl execute // DefaultKarmadactlCommandDuration defines the default timeout for karmadactl execute

2
pkg/karmadactl/promote.go
View File

@ -95,7 +95,7 @@ type CommandPromoteOption struct {
// Cluster is the name of legacy cluster // Cluster is the name of legacy cluster
Cluster string Cluster string
// ClusterNamespace holds the namespace name where the member cluster objects are stored. // ClusterNamespace holds the namespace name where the member cluster secrets are stored.
ClusterNamespace string ClusterNamespace string
// Namespace is the namespace of legacy resource // Namespace is the namespace of legacy resource

2
pkg/karmadactl/unjoin.go
View File

@ -73,7 +73,7 @@ func unjoinExample(parentCommand string) string {
type CommandUnjoinOption struct { type CommandUnjoinOption struct {
options.GlobalCommandOptions options.GlobalCommandOptions
// ClusterNamespace holds the namespace name where the member cluster objects are stored. // ClusterNamespace holds namespace where the member cluster secrets are stored
ClusterNamespace string ClusterNamespace string
// ClusterName is the cluster's name that we are going to join with. // ClusterName is the cluster's name that we are going to join with.