karmada-io
/
karmada
mirror of https://github.com/karmada-io/karmada.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

operator/pkg/certs/store_test: fix flaky test 

In this commit, we fix flaky test in `store_test.go` by using
`GetCert` to retrieve secrets instead of unreliable `CertList`
indexing due to non-guarnteed map order.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
This commit is contained in:
Mohamed Awnallah 2024-10-21 16:24:55 +03:00
parent 6a827f60bc
commit 6c68781889
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
operator/pkg/certs/store_test.go
View File

@ -60,10 +60,11 @@ func TestAddAndGetCert(t *testing.T) {
}
func TestCertList(t *testing.T) {
cert1Name, cert2Name := "cert1", "cert2"
store := NewCertStore()
cert1 := newKarmadaCert("cert1", []byte("cert1Data"), []byte("key1Data"))
cert2 := newKarmadaCert("cert2", []byte("cert2Data"), []byte("key2Data"))
cert1 := newKarmadaCert(cert1Name, []byte("cert1Data"), []byte("key1Data"))
cert2 := newKarmadaCert(cert2Name, []byte("cert2Data"), []byte("key2Data"))
store.AddCert(cert1)
store.AddCert(cert2)
@ -71,8 +72,11 @@ func TestCertList(t *testing.T) {
if len(certs) != 2 {
t.Errorf("expected 2 certs but got %d", len(certs))
}
if certs[0].pairName != "cert1" || certs[1].pairName != "cert2" {
t.Errorf("cert list does not match expected values")
if cert1 = store.GetCert(cert1Name); cert1 == nil {
t.Errorf("expected to retrieve %s, but got nil", cert1Name)
}
if cert2 = store.GetCert(cert2Name); cert2 == nil {
t.Errorf("expected to retrieve %s, but got nil", cert2Name)
}
}