karmada-io
/
karmada
mirror of https://github.com/karmada-io/karmada.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1653 from Poor12/add-desheduler 

Add warnings when config cluster-namespace as karmada-system
This commit is contained in:
karmada-bot 2022-08-09 18:50:08 +08:00 committed by GitHub
parent 67fd394e5e 41bf329bde
commit 6f4b24a26d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/karmadactl/join.go
View File

@ -113,6 +113,9 @@ func (j *CommandJoinOption) Validate(args []string) error {
return fmt.Errorf("invalid cluster name(%s): %s", j.ClusterName, strings.Join(errMsgs, ";")) return fmt.Errorf("invalid cluster name(%s): %s", j.ClusterName, strings.Join(errMsgs, ";"))
} }
if j.ClusterNamespace == util.NamespaceKarmadaSystem {
klog.Warningf("karmada-system is always reserved for Karmada control plane. We do not recommend using karmada-system to store secrets of member clusters. It may cause mistaken cleanup of resources.")
}
return nil return nil
} }