karmada-io
/
karmada
mirror of https://github.com/karmada-io/karmada.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5875 from mohamedawnallah/addressSearchControllerFlakeTest 

pkg/search/controllers_test: address flaky test
This commit is contained in:
karmada-bot 2024-11-28 19:23:03 +08:00 committed by GitHub
parent c8b033d47d fcfbf700cd
commit 6f4d69cf8b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 33 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
pkg/search/controllers_test.go
View File

@ -22,6 +22,7 @@ import (
"fmt"
"strings"
"testing"
"time"
apierrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/api/meta"
@ -134,7 +135,7 @@ func TestAddClusterEventHandler(t *testing.T) {
restMapper: meta.NewDefaultRESTMapper(nil),
stopCh: make(chan struct{}),
prep: func(clientConnector *fakekarmadaclient.Clientset, restConfig *rest.Config, restMapper meta.RESTMapper) (*Controller, informerfactory.SharedInformerFactory, error) {
factory := informerfactory.NewSharedInformerFactory(clientConnector, 0)
factory := informerfactory.NewSharedInformerFactory(clientConnector, time.Second)
controller, err := createController(restConfig, factory, restMapper)
return controller, factory, err
},
@ -162,6 +163,7 @@ func TestAddClusterEventHandler(t *testing.T) {
t.Fatalf("failed to prepare test environment for event handler setup, got: %v", err)
}
informer.Start(test.stopCh)
defer informer.Shutdown()
defer close(test.stopCh)
if err := test.verify(test.client, controller); err != nil {
@ -188,7 +190,7 @@ func TestUpdateClusterEventHandler(t *testing.T) {
restMapper: meta.NewDefaultRESTMapper(nil),
stopCh: make(chan struct{}),
prep: func(clientConnector *fakekarmadaclient.Clientset, restConfig *rest.Config, restMapper meta.RESTMapper) (*Controller, informerfactory.SharedInformerFactory, error) {
factory := informerfactory.NewSharedInformerFactory(clientConnector, 0)
factory := informerfactory.NewSharedInformerFactory(clientConnector, time.Second)
controller, err := createController(restConfig, factory, restMapper)
return controller, factory, err
},
@ -223,6 +225,7 @@ func TestUpdateClusterEventHandler(t *testing.T) {
t.Fatalf("failed to prepare test environment for event handler setup, got: %v", err)
}
informer.Start(test.stopCh)
defer informer.Shutdown()
defer close(test.stopCh)
if err := test.verify(test.client, controller); err != nil {
@ -249,7 +252,7 @@ func TestDeleteClusterEventHandler(t *testing.T) {
restMapper: restmapper.NewDiscoveryRESTMapper(apiGroupResources),
stopCh: make(chan struct{}),
prep: func(clientConnector *fakekarmadaclient.Clientset, restConfig *rest.Config, restMapper meta.RESTMapper) (*Controller, informerfactory.SharedInformerFactory, error) {
factory := informerfactory.NewSharedInformerFactory(clientConnector, 0)
factory := informerfactory.NewSharedInformerFactory(clientConnector, time.Second)
controller, err := createController(restConfig, factory, restMapper)
return controller, factory, err
},
@ -310,6 +313,7 @@ func TestDeleteClusterEventHandler(t *testing.T) {
t.Fatalf("failed to prepare test environment for event handler setup, got: %v", err)
}
informer.Start(test.stopCh)
defer informer.Shutdown()
defer close(test.stopCh)
if err := test.verify(test.client, controller); err != nil {
@ -336,7 +340,7 @@ func TestAddResourceRegistryEventHandler(t *testing.T) {
restMapper: restmapper.NewDiscoveryRESTMapper(apiGroupResources),
stopCh: make(chan struct{}),
prep: func(clientConnector *fakekarmadaclient.Clientset, restConfig *rest.Config, restMapper meta.RESTMapper) (*Controller, informerfactory.SharedInformerFactory, error) {
factory := informerfactory.NewSharedInformerFactory(clientConnector, 0)
factory := informerfactory.NewSharedInformerFactory(clientConnector, time.Second)
controller, err := createController(restConfig, factory, restMapper)
return controller, factory, err
},
@ -385,6 +389,7 @@ func TestAddResourceRegistryEventHandler(t *testing.T) {
t.Fatalf("failed to prepare test environment for event handler setup, got: %v", err)
}
informer.Start(test.stopCh)
defer informer.Shutdown()
defer close(test.stopCh)
if err := test.verify(test.client, controller); err != nil {
@ -411,7 +416,7 @@ func TestUpdateResourceRegistryEventHandler(t *testing.T) {
restMapper: restmapper.NewDiscoveryRESTMapper(apiGroupResources),
stopCh: make(chan struct{}),
prep: func(clientConnector *fakekarmadaclient.Clientset, restConfig *rest.Config, restMapper meta.RESTMapper) (*Controller, informerfactory.SharedInformerFactory, error) {
factory := informerfactory.NewSharedInformerFactory(clientConnector, 0)
factory := informerfactory.NewSharedInformerFactory(clientConnector, time.Second)
controller, err := createController(restConfig, factory, restMapper)
return controller, factory, err
},
@ -476,6 +481,7 @@ func TestUpdateResourceRegistryEventHandler(t *testing.T) {
t.Fatalf("failed to prepare test environment for event handler setup, got: %v", err)
}
informer.Start(test.stopCh)
defer informer.Shutdown()
defer close(test.stopCh)
if err := test.verify(test.client, controller); err != nil {
@ -502,7 +508,7 @@ func TestDeleteResourceRegistryEventHandler(t *testing.T) {
restMapper: restmapper.NewDiscoveryRESTMapper(apiGroupResources),
stopCh: make(chan struct{}),
prep: func(clientConnector *fakekarmadaclient.Clientset, restConfig *rest.Config, restMapper meta.RESTMapper) (*Controller, informerfactory.SharedInformerFactory, error) {
factory := informerfactory.NewSharedInformerFactory(clientConnector, 0)
factory := informerfactory.NewSharedInformerFactory(clientConnector, time.Second)
controller, err := createController(restConfig, factory, restMapper)
return controller, factory, err
},
@ -558,6 +564,7 @@ func TestDeleteResourceRegistryEventHandler(t *testing.T) {
t.Fatalf("failed to prepare test environment for event handler setup, got: %v", err)
}
informer.Start(test.stopCh)
defer informer.Shutdown()
defer close(test.stopCh)
if err := test.verify(test.client, controller); err != nil {
@ -597,6 +604,26 @@ func upsertCluster(client *fakekarmadaclient.Clientset, labels map[string]string
Status: metav1.ConditionTrue,
},
},
APIEnablements: []clusterv1alpha1.APIEnablement{
{
GroupVersion: "apps/v1",
Resources: []clusterv1alpha1.APIResource{
{
Name: "deployments",
Kind: "Deployment",
},
},
},
{
GroupVersion: "v1",
Resources: []clusterv1alpha1.APIResource{
{
Name: "pods",
Kind: "Pod",
},
},
},
},
},
}