From f888ec07fa2182d6e77fd31275e0ce276ece12f3 Mon Sep 17 00:00:00 2001 From: Fish-pro Date: Fri, 10 Feb 2023 10:59:40 +0800 Subject: [PATCH] Optimize invalid unit tests Signed-off-by: Fish-pro --- pkg/registry/cluster/strategy_test.go | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/pkg/registry/cluster/strategy_test.go b/pkg/registry/cluster/strategy_test.go index 9633c3f42..e2b792c6f 100644 --- a/pkg/registry/cluster/strategy_test.go +++ b/pkg/registry/cluster/strategy_test.go @@ -277,23 +277,30 @@ func TestStrategy_AllowUnconditionalUpdate(t *testing.T) { func TestStrategy_Canonicalize(t *testing.T) { clusterStrategy := NewStrategy(clusterscheme.Scheme) - clusterBefore := getValidCluster("cluster") - clusterAfter := getValidCluster("cluster") - clusterAfter.Spec.Taints = []corev1.Taint{ + cluster := getValidCluster("cluster") + cluster.Spec.Taints = []corev1.Taint{ { Key: "foo", - Value: "abc", + Value: "bar", Effect: corev1.TaintEffectNoSchedule, }, { - Key: "bar", + Key: "foo1", + Value: "bar1", Effect: corev1.TaintEffectNoExecute, }, } - clusterStrategy.Canonicalize(clusterBefore) - if !reflect.DeepEqual(clusterAfter, clusterAfter) { - t.Errorf("Object mismatch! Excepted: \n%#v \ngot: \n%#v", clusterAfter, clusterAfter) + clusterStrategy.Canonicalize(cluster) + success := true + for _, taint := range cluster.Spec.Taints { + if taint.Effect == corev1.TaintEffectNoExecute && taint.TimeAdded == nil { + success = false + break + } + } + if !success { + t.Errorf("cluster canonicalize error, got: \n%#v", cluster) } }