Add UT for pkg/controllers/binding/binding_controller.go
Signed-off-by: zishen <softwarebtg@163.com>
This commit is contained in:
zishen
parent
db3a907c24
commit
8391b233c4
|
|
@ -0,0 +1,296 @@
|
|||
package binding
|
||||
|
||||
import (
|
||||
"context"
|
||||
"fmt"
|
||||
"reflect"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
appsv1 "k8s.io/api/apps/v1"
|
||||
corev1 "k8s.io/api/core/v1"
|
||||
"k8s.io/apimachinery/pkg/api/meta"
|
||||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
||||
"k8s.io/apimachinery/pkg/runtime"
|
||||
"k8s.io/apimachinery/pkg/types"
|
||||
fakedynamic "k8s.io/client-go/dynamic/fake"
|
||||
"k8s.io/client-go/kubernetes/scheme"
|
||||
"k8s.io/client-go/tools/record"
|
||||
controllerruntime "sigs.k8s.io/controller-runtime"
|
||||
"sigs.k8s.io/controller-runtime/pkg/client"
|
||||
"sigs.k8s.io/controller-runtime/pkg/client/fake"
|
||||
|
||||
policyv1alpha1 "github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1"
|
||||
workv1alpha2 "github.com/karmada-io/karmada/pkg/apis/work/v1alpha2"
|
||||
testing2 "github.com/karmada-io/karmada/pkg/search/proxy/testing"
|
||||
"github.com/karmada-io/karmada/pkg/util/fedinformer/genericmanager"
|
||||
"github.com/karmada-io/karmada/pkg/util/gclient"
|
||||
testing3 "github.com/karmada-io/karmada/pkg/util/testing"
|
||||
"github.com/karmada-io/karmada/test/helper"
|
||||
)
|
||||
|
||||
// makeFakeRBCByResource to make a fake ResourceBindingController with ObjectReference.
|
||||
// Currently support kind: Pod,Node. If you want support more kind, pls add it.
|
||||
// rs is nil means use default RestMapper, see: github.com/karmada-io/karmada/pkg/search/proxy/testing/constant.go
|
||||
func makeFakeRBCByResource(rs *workv1alpha2.ObjectReference) (*ResourceBindingController, error) {
|
||||
tempDyClient := fakedynamic.NewSimpleDynamicClient(scheme.Scheme)
|
||||
if rs == nil {
|
||||
return &ResourceBindingController{
|
||||
Client: fake.NewClientBuilder().WithScheme(gclient.NewSchema()).Build(),
|
||||
RESTMapper: testing2.RestMapper,
|
||||
InformerManager: genericmanager.NewSingleClusterInformerManager(tempDyClient, 0, nil),
|
||||
DynamicClient: tempDyClient,
|
||||
}, nil
|
||||
}
|
||||
|
||||
var obj runtime.Object
|
||||
var src string
|
||||
switch rs.Kind {
|
||||
case "Pod":
|
||||
obj = &corev1.Pod{ObjectMeta: metav1.ObjectMeta{Name: rs.Name, Namespace: rs.Namespace}}
|
||||
src = "pods"
|
||||
case "Node":
|
||||
obj = &corev1.Node{ObjectMeta: metav1.ObjectMeta{Name: rs.Name, Namespace: rs.Namespace}}
|
||||
src = "nodes"
|
||||
default:
|
||||
return nil, fmt.Errorf("%s not support yet, pls add for it", rs.Kind)
|
||||
}
|
||||
|
||||
tempDyClient.Resources = []*metav1.APIResourceList{
|
||||
{
|
||||
GroupVersion: appsv1.SchemeGroupVersion.String(),
|
||||
APIResources: []metav1.APIResource{
|
||||
{Name: rs.Name, Namespaced: true, Kind: rs.Kind, Version: rs.APIVersion},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
return &ResourceBindingController{
|
||||
Client: fake.NewClientBuilder().WithScheme(gclient.NewSchema()).Build(),
|
||||
RESTMapper: helper.NewGroupRESTMapper(rs.Kind, meta.RESTScopeNamespace),
|
||||
InformerManager: testing3.NewSingleClusterInformerManagerByRS(src, obj),
|
||||
DynamicClient: tempDyClient,
|
||||
EventRecorder: record.NewFakeRecorder(1024),
|
||||
}, nil
|
||||
}
|
||||
|
||||
func TestResourceBindingController_Reconcile(t *testing.T) {
|
||||
preTime := metav1.Date(2023, 0, 0, 0, 0, 0, 0, time.UTC)
|
||||
tmpReq := controllerruntime.Request{
|
||||
NamespacedName: types.NamespacedName{
|
||||
Name: "test-rb",
|
||||
Namespace: "default",
|
||||
},
|
||||
}
|
||||
tests := []struct {
|
||||
name string
|
||||
want controllerruntime.Result
|
||||
wantErr bool
|
||||
rb *workv1alpha2.ResourceBinding
|
||||
req controllerruntime.Request
|
||||
}{
|
||||
{
|
||||
name: "Err is RB not found",
|
||||
want: controllerruntime.Result{},
|
||||
wantErr: false,
|
||||
req: tmpReq,
|
||||
},
|
||||
{
|
||||
name: "RB found with deleting",
|
||||
want: controllerruntime.Result{},
|
||||
wantErr: false,
|
||||
rb: &workv1alpha2.ResourceBinding{
|
||||
ObjectMeta: metav1.ObjectMeta{
|
||||
Name: "test-rb",
|
||||
Namespace: "default",
|
||||
DeletionTimestamp: &preTime,
|
||||
},
|
||||
},
|
||||
req: tmpReq,
|
||||
},
|
||||
{
|
||||
name: "RB found without deleting",
|
||||
want: controllerruntime.Result{Requeue: true},
|
||||
wantErr: true,
|
||||
rb: &workv1alpha2.ResourceBinding{
|
||||
ObjectMeta: metav1.ObjectMeta{
|
||||
Name: "test-rb",
|
||||
Namespace: "default",
|
||||
},
|
||||
},
|
||||
req: tmpReq,
|
||||
},
|
||||
{
|
||||
name: "Req not found",
|
||||
want: controllerruntime.Result{Requeue: false},
|
||||
wantErr: false,
|
||||
rb: &workv1alpha2.ResourceBinding{
|
||||
ObjectMeta: metav1.ObjectMeta{
|
||||
Name: "haha-rb",
|
||||
Namespace: "default",
|
||||
},
|
||||
},
|
||||
req: tmpReq,
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
c, makeErr := makeFakeRBCByResource(nil)
|
||||
if makeErr != nil {
|
||||
t.Errorf("makeFakeRBCByResource %v", makeErr)
|
||||
return
|
||||
}
|
||||
if tt.rb != nil {
|
||||
// Add a rb to the fake client.
|
||||
if err := c.Client.Create(context.Background(), tt.rb); err != nil {
|
||||
t.Fatalf("Failed to create rb: %v", err)
|
||||
}
|
||||
}
|
||||
// Run the reconcile function.
|
||||
got, err := c.Reconcile(context.Background(), tt.req)
|
||||
// Check the results.
|
||||
if tt.wantErr && err == nil {
|
||||
t.Errorf("Expected an error but got nil")
|
||||
} else if !tt.wantErr && err != nil {
|
||||
t.Errorf("Expected no error but got %v", err)
|
||||
}
|
||||
if !reflect.DeepEqual(got, tt.want) {
|
||||
t.Errorf("Reconcile() got = %v, want %v", got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestResourceBindingController_syncBinding(t *testing.T) {
|
||||
rs := workv1alpha2.ObjectReference{
|
||||
APIVersion: "v1",
|
||||
Kind: "Pod",
|
||||
Namespace: "default",
|
||||
Name: "pod",
|
||||
}
|
||||
tests := []struct {
|
||||
name string
|
||||
want controllerruntime.Result
|
||||
wantErr bool
|
||||
rb *workv1alpha2.ResourceBinding
|
||||
}{
|
||||
{
|
||||
name: "syncBinding success test",
|
||||
want: controllerruntime.Result{},
|
||||
wantErr: false,
|
||||
rb: &workv1alpha2.ResourceBinding{
|
||||
ObjectMeta: metav1.ObjectMeta{
|
||||
Name: "test-rb",
|
||||
Namespace: "default",
|
||||
},
|
||||
Spec: workv1alpha2.ResourceBindingSpec{
|
||||
Resource: rs,
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
c, makeErr := makeFakeRBCByResource(&rs)
|
||||
if makeErr != nil {
|
||||
t.Errorf("makeFakeRBCByResource %v", makeErr)
|
||||
return
|
||||
}
|
||||
got, err := c.syncBinding(tt.rb)
|
||||
if (err != nil) != tt.wantErr {
|
||||
t.Errorf("syncBinding() error = %v, wantErr %v", err, tt.wantErr)
|
||||
return
|
||||
}
|
||||
if !reflect.DeepEqual(got, tt.want) {
|
||||
t.Errorf("syncBinding() got = %v, want %v", got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestResourceBindingController_removeOrphanWorks(t *testing.T) {
|
||||
rs := workv1alpha2.ObjectReference{
|
||||
APIVersion: "v1",
|
||||
Kind: "Pod",
|
||||
Namespace: "default",
|
||||
Name: "pod",
|
||||
}
|
||||
tests := []struct {
|
||||
name string
|
||||
wantErr bool
|
||||
rb *workv1alpha2.ResourceBinding
|
||||
}{
|
||||
{
|
||||
name: "removeOrphanWorks success test",
|
||||
wantErr: false,
|
||||
rb: &workv1alpha2.ResourceBinding{
|
||||
ObjectMeta: metav1.ObjectMeta{
|
||||
Name: "test-rb",
|
||||
Namespace: "default",
|
||||
},
|
||||
Spec: workv1alpha2.ResourceBindingSpec{
|
||||
Resource: rs,
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
c, makeErr := makeFakeRBCByResource(&rs)
|
||||
if makeErr != nil {
|
||||
t.Errorf("makeFakeRBCByResource %v", makeErr)
|
||||
return
|
||||
}
|
||||
if err := c.removeOrphanWorks(tt.rb); (err != nil) != tt.wantErr {
|
||||
t.Errorf("removeOrphanWorks() error = %v, wantErr %v", err, tt.wantErr)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestResourceBindingController_newOverridePolicyFunc(t *testing.T) {
|
||||
rs := workv1alpha2.ObjectReference{
|
||||
APIVersion: "v1",
|
||||
Kind: "Pod",
|
||||
Namespace: "default",
|
||||
Name: "pod",
|
||||
}
|
||||
tests := []struct {
|
||||
name string
|
||||
want bool
|
||||
obIsNil bool
|
||||
}{
|
||||
{
|
||||
name: "newOverridePolicyFunc success test",
|
||||
want: false,
|
||||
obIsNil: false,
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
tempOP := &policyv1alpha1.OverridePolicy{
|
||||
ObjectMeta: metav1.ObjectMeta{Namespace: rs.Namespace},
|
||||
Spec: policyv1alpha1.OverrideSpec{ResourceSelectors: []policyv1alpha1.ResourceSelector{
|
||||
{
|
||||
APIVersion: rs.APIVersion,
|
||||
Kind: rs.Kind,
|
||||
Namespace: rs.Namespace,
|
||||
Name: rs.Name,
|
||||
},
|
||||
}},
|
||||
}
|
||||
c, makeErr := makeFakeRBCByResource(&rs)
|
||||
if makeErr != nil {
|
||||
t.Errorf("makeFakeRBCByResource %v", makeErr)
|
||||
return
|
||||
}
|
||||
got := c.newOverridePolicyFunc()
|
||||
if (got == nil) != tt.want {
|
||||
t.Errorf("newOverridePolicyFunc() is not same as want:%v", tt.want)
|
||||
}
|
||||
if (got(client.Object(tempOP)) == nil) == tt.obIsNil {
|
||||
t.Errorf("newOverridePolicyFunc() got() result is not same as want: %v", tt.obIsNil)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,20 @@
|
|||
package testing
|
||||
|
||||
import (
|
||||
corev1 "k8s.io/api/core/v1"
|
||||
"k8s.io/apimachinery/pkg/runtime"
|
||||
fakedynamic "k8s.io/client-go/dynamic/fake"
|
||||
"k8s.io/client-go/kubernetes/scheme"
|
||||
|
||||
"github.com/karmada-io/karmada/pkg/util/fedinformer/genericmanager"
|
||||
)
|
||||
|
||||
// NewSingleClusterInformerManagerByRS will build a fake SingleClusterInformerManager and can add resource.
|
||||
func NewSingleClusterInformerManagerByRS(src string, obj runtime.Object) genericmanager.SingleClusterInformerManager {
|
||||
c := fakedynamic.NewSimpleDynamicClient(scheme.Scheme, obj)
|
||||
m := genericmanager.NewSingleClusterInformerManager(c, 0, nil)
|
||||
m.Lister(corev1.SchemeGroupVersion.WithResource(src))
|
||||
m.Start()
|
||||
m.WaitForCacheSync()
|
||||
return m
|
||||
}
|
||||
|
|
@ -0,0 +1,14 @@
|
|||
package helper
|
||||
|
||||
import (
|
||||
corev1 "k8s.io/api/core/v1"
|
||||
"k8s.io/apimachinery/pkg/api/meta"
|
||||
"k8s.io/apimachinery/pkg/runtime/schema"
|
||||
)
|
||||
|
||||
// NewGroupRESTMapper make a fake RESTMapper in GroupVersion, by kind and scope.
|
||||
func NewGroupRESTMapper(kind string, scope meta.RESTScope) meta.RESTMapper {
|
||||
m := meta.NewDefaultRESTMapper([]schema.GroupVersion{corev1.SchemeGroupVersion})
|
||||
m.Add(corev1.SchemeGroupVersion.WithKind(kind), scope)
|
||||
return m
|
||||
}
|
||||
Loading…
Reference in New Issue