From 4d49f36d09d791689a7fee747e3c9da12d55dc15 Mon Sep 17 00:00:00 2001 From: Yash Pandey Date: Fri, 9 Aug 2024 20:19:10 +0530 Subject: [PATCH] Added unit test cluster_condition coverage : 100% (squashed commit) Signed-off-by: Yash Pandey Signed-off-by: Yash Pandey --- .../status/cluster_condition_cache_test.go | 54 +++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/pkg/controllers/status/cluster_condition_cache_test.go b/pkg/controllers/status/cluster_condition_cache_test.go index aed6f985d..11747d581 100644 --- a/pkg/controllers/status/cluster_condition_cache_test.go +++ b/pkg/controllers/status/cluster_condition_cache_test.go @@ -176,6 +176,60 @@ func TestThresholdAdjustedReadyCondition(t *testing.T) { Status: metav1.ConditionTrue, }, }, + { + name: "ready condition changes from true to false", + clusterData: &clusterData{ + readyCondition: metav1.ConditionTrue, + thresholdStartTime: time.Now().Add(-10 * time.Minute), + }, + currentCondition: &metav1.Condition{ + Type: clusterv1alpha1.ClusterConditionReady, + Status: metav1.ConditionTrue, + }, + observedCondition: &metav1.Condition{ + Type: clusterv1alpha1.ClusterConditionReady, + Status: metav1.ConditionFalse, + }, + expectedCondition: &metav1.Condition{ + Type: clusterv1alpha1.ClusterConditionReady, + Status: metav1.ConditionTrue, + }, + }, + { + name: "ready condition changes from false to true", + clusterData: &clusterData{ + readyCondition: metav1.ConditionFalse, + thresholdStartTime: time.Now().Add(-10 * time.Minute), + }, + currentCondition: &metav1.Condition{ + Type: clusterv1alpha1.ClusterConditionReady, + Status: metav1.ConditionFalse, + }, + observedCondition: &metav1.Condition{ + Type: clusterv1alpha1.ClusterConditionReady, + Status: metav1.ConditionTrue, + }, + expectedCondition: &metav1.Condition{ + Type: clusterv1alpha1.ClusterConditionReady, + Status: metav1.ConditionFalse, + }, + }, + { + name: "current condition is nil, should return observed condition", + clusterData: &clusterData{ + readyCondition: metav1.ConditionFalse, + thresholdStartTime: time.Now().Add(-clusterFailureThreshold), + }, + currentCondition: nil, + observedCondition: &metav1.Condition{ + Type: clusterv1alpha1.ClusterConditionReady, + Status: metav1.ConditionTrue, + }, + expectedCondition: &metav1.Condition{ + Type: clusterv1alpha1.ClusterConditionReady, + Status: metav1.ConditionTrue, + }, + }, } for _, tt := range tests {