Merge pull request #544 from qianjun1993/scheduler-queue

never drop binding in scheduler when failed
This commit is contained in:
karmada-bot 2021-07-22 08:58:45 +08:00 committed by GitHub
commit 9f2283c281
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 18 deletions

View File

@ -12,7 +12,6 @@ import (
"k8s.io/apimachinery/pkg/api/meta" "k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/labels" "k8s.io/apimachinery/pkg/labels"
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
"k8s.io/apimachinery/pkg/util/sets" "k8s.io/apimachinery/pkg/util/sets"
"k8s.io/apimachinery/pkg/util/wait" "k8s.io/apimachinery/pkg/util/wait"
"k8s.io/client-go/dynamic" "k8s.io/client-go/dynamic"
@ -37,15 +36,6 @@ import (
"github.com/karmada-io/karmada/pkg/util" "github.com/karmada-io/karmada/pkg/util"
) )
const (
// maxRetries is the number of times a service will be retried before it is dropped out of the queue.
// With the current rate-limiter in use (5ms*2^(maxRetries-1)) the following numbers represent the
// sequence of delays between successive queuings of a propagationbinding.
//
// 5ms, 10ms, 20ms, 40ms, 80ms, 160ms, 320ms, 640ms, 1.3s, 2.6s, 5.1s, 10.2s, 20.4s, 41s, 82s
maxRetries = 15
)
// ScheduleType defines the schedule type of a binding object should be performed. // ScheduleType defines the schedule type of a binding object should be performed.
type ScheduleType string type ScheduleType string
@ -548,14 +538,7 @@ func (s *Scheduler) handleErr(err error, key interface{}) {
return return
} }
if s.queue.NumRequeues(key) < maxRetries {
s.queue.AddRateLimited(key) s.queue.AddRateLimited(key)
return
}
utilruntime.HandleError(err)
klog.V(2).Infof("Dropping ResourceBinding %q out of the queue: %v", key, err)
s.queue.Forget(key)
} }
func (s *Scheduler) addCluster(obj interface{}) { func (s *Scheduler) addCluster(obj interface{}) {