From 7fb59a8b628ddd4f98860813ddc15d4139111010 Mon Sep 17 00:00:00 2001 From: wei-chenglai Date: Sat, 12 Apr 2025 00:29:11 -0400 Subject: [PATCH] Fix lint issue QF1004 Signed-off-by: wei-chenglai --- .golangci.yml | 1 - hack/tools/gencomponentdocs/postprocessing.go | 2 +- hack/tools/genkarmadactldocs/gen_karmadactl_docs.go | 4 ++-- pkg/karmadactl/util/bootstraptoken/bootstraptoken.go | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 1cb6b2512..ddb32af59 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -72,7 +72,6 @@ linters: - "-QF1008" - "-ST1019" - "-ST1005" - - "-QF1004" - "-ST1011" - "-QF1003" - "-QF1001" diff --git a/hack/tools/gencomponentdocs/postprocessing.go b/hack/tools/gencomponentdocs/postprocessing.go index 9c6736091..13583042e 100644 --- a/hack/tools/gencomponentdocs/postprocessing.go +++ b/hack/tools/gencomponentdocs/postprocessing.go @@ -35,7 +35,7 @@ func MarkdownPostProcessing(cmd *cobra.Command, dir string, processor func(strin } } - basename := strings.Replace(cmd.CommandPath(), " ", "_", -1) + ".md" + basename := strings.ReplaceAll(cmd.CommandPath(), " ", "_") + ".md" filename := filepath.Join(dir, basename) // Remove the markdown file for the version subcommand diff --git a/hack/tools/genkarmadactldocs/gen_karmadactl_docs.go b/hack/tools/genkarmadactldocs/gen_karmadactl_docs.go index 628acf6da..d02b93d32 100644 --- a/hack/tools/genkarmadactldocs/gen_karmadactl_docs.go +++ b/hack/tools/genkarmadactldocs/gen_karmadactl_docs.go @@ -46,7 +46,7 @@ func PrintCLIByTag(cmd *cobra.Command, all []*cobra.Command, tag string) string } cname := cmd.Name() + " " + c.Name() link := cname - link = strings.Replace(link, " ", "_", -1) + ".md" + link = strings.ReplaceAll(link, " ", "_") + ".md" pl = append(pl, fmt.Sprintf("* [%s](%s)\t - %s\n", cname, link, c.Long)) } @@ -59,7 +59,7 @@ func PrintCLIByTag(cmd *cobra.Command, all []*cobra.Command, tag string) string // GenMarkdownTreeForIndex generate the index page for karmadactl func GenMarkdownTreeForIndex(cmd *cobra.Command, dir string) error { - basename := strings.Replace(cmd.CommandPath(), " ", "_", -1) + "_index" + ".md" + basename := strings.ReplaceAll(cmd.CommandPath(), " ", "_") + "_index" + ".md" filename := filepath.Join(dir, basename) f, err := os.OpenFile(filename, os.O_CREATE|os.O_RDWR, pkgutil.DefaultFilePerm) if err != nil { diff --git a/pkg/karmadactl/util/bootstraptoken/bootstraptoken.go b/pkg/karmadactl/util/bootstraptoken/bootstraptoken.go index f0d6458e1..d102295dc 100644 --- a/pkg/karmadactl/util/bootstraptoken/bootstraptoken.go +++ b/pkg/karmadactl/util/bootstraptoken/bootstraptoken.go @@ -138,7 +138,7 @@ func GenerateRegisterCommand(kubeConfig, parentCommand, token string, karmadaCon } return fmt.Sprintf("%s register %s --token %s --discovery-token-ca-cert-hash %s", - parentCommand, strings.Replace(clusterConfig.Server, "https://", "", -1), + parentCommand, strings.ReplaceAll(clusterConfig.Server, "https://", ""), token, strings.Join(publicKeyPins, ",")), nil }