karmada-io
/
karmada
mirror of https://github.com/karmada-io/karmada.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4498 from chaosi-zju/lint-error-strings 

cleanup: enable revive(error-strings) checking
This commit is contained in:
karmada-bot 2024-01-03 11:03:27 +08:00 committed by GitHub
parent b69ead80d8 25b67f54d6
commit a1c1eedcc7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.golangci.yml
View File

@ -69,6 +69,7 @@ linters-settings:
- name: superfluous-else - name: superfluous-else
arguments: arguments:
- preserveScope - preserveScope
- name: error-strings
staticcheck: staticcheck:
checks: checks:
- all - all

6
pkg/controllers/hpareplicassyncer/hpa_replicas_syncer_controller_test.go
View File

@ -190,7 +190,7 @@ func reactionFuncForGetting(c client.Client, mapper meta.RESTMapper) coretesting
return func(action coretesting.Action) (bool, runtime.Object, error) { return func(action coretesting.Action) (bool, runtime.Object, error) {
getAction, ok := action.(coretesting.GetAction) getAction, ok := action.(coretesting.GetAction)
if !ok { if !ok {
return false, nil, fmt.Errorf("Not GET Action!") return false, nil, fmt.Errorf("not GET Action")
} }
obj, err := newUnstructured(getAction.GetResource(), mapper) obj, err := newUnstructured(getAction.GetResource(), mapper)
@ -243,12 +243,12 @@ func reactionFuncForUpdating(c client.Client, mapper meta.RESTMapper) coretestin
return func(action coretesting.Action) (bool, runtime.Object, error) { return func(action coretesting.Action) (bool, runtime.Object, error) {
updateAction, ok := action.(coretesting.UpdateAction) updateAction, ok := action.(coretesting.UpdateAction)
if !ok { if !ok {
return false, nil, fmt.Errorf("Not UPDATE Action!") return false, nil, fmt.Errorf("not UPDATE Action")
} }
scale, ok := updateAction.GetObject().(*autoscalingv1.Scale) scale, ok := updateAction.GetObject().(*autoscalingv1.Scale)
if !ok { if !ok {
return false, nil, fmt.Errorf("Not autoscalingv1.Scale Object!") return false, nil, fmt.Errorf("not autoscalingv1.Scale Object")
} }
obj, err := newUnstructured(updateAction.GetResource(), mapper) obj, err := newUnstructured(updateAction.GetResource(), mapper)