fatal when errors heppen in karmadactl

Signed-off-by: lihanbo <lihanbo2@huawei.com>
This commit is contained in:
lihanbo 2021-10-18 20:53:57 +08:00
parent 41f0cb136a
commit a643c093f1
3 changed files with 8 additions and 15 deletions

View File

@ -52,18 +52,16 @@ func NewCmdCordon(cmdOut io.Writer, karmadaConfig KarmadaConfig, cmdStr string)
Run: func(cmd *cobra.Command, args []string) { Run: func(cmd *cobra.Command, args []string) {
err := opts.Complete(args) err := opts.Complete(args)
if err != nil { if err != nil {
klog.Errorf("Error: %v", err) klog.Fatalf("Error: %v", err)
return
} }
if errs := opts.Validate(); len(errs) != 0 { if errs := opts.Validate(); len(errs) != 0 {
klog.Error(utilerrors.NewAggregate(errs).Error()) klog.Fatalf("Error: %v", utilerrors.NewAggregate(errs).Error())
return
} }
err = RunCordonOrUncordon(cmdOut, desiredCordon, karmadaConfig, opts) err = RunCordonOrUncordon(cmdOut, desiredCordon, karmadaConfig, opts)
if err != nil { if err != nil {
klog.Errorf("Error: %v", err) klog.Fatalf("Error: %v", err)
return return
} }
}, },

View File

@ -70,19 +70,16 @@ func NewCmdJoin(cmdOut io.Writer, karmadaConfig KarmadaConfig, cmdStr string) *c
// Set default values // Set default values
err := opts.Complete(args) err := opts.Complete(args)
if err != nil { if err != nil {
klog.Errorf("Error: %v", err) klog.Fatalf("Error: %v", err)
return
} }
if errs := opts.Validate(); len(errs) != 0 { if errs := opts.Validate(); len(errs) != 0 {
klog.Error(utilerrors.NewAggregate(errs).Error()) klog.Fatalf("Error: %v", utilerrors.NewAggregate(errs).Error())
return
} }
err = RunJoin(cmdOut, karmadaConfig, opts) err = RunJoin(cmdOut, karmadaConfig, opts)
if err != nil { if err != nil {
klog.Errorf("Error: %v", err) klog.Fatalf("Error: %v", err)
return
} }
}, },
} }

View File

@ -42,14 +42,12 @@ func NewCmdUnjoin(cmdOut io.Writer, karmadaConfig KarmadaConfig, cmdStr string)
Run: func(cmd *cobra.Command, args []string) { Run: func(cmd *cobra.Command, args []string) {
err := opts.Complete(args) err := opts.Complete(args)
if err != nil { if err != nil {
klog.Errorf("Error: %v", err) klog.Fatalf("Error: %v", err)
return
} }
err = RunUnjoin(cmdOut, karmadaConfig, opts) err = RunUnjoin(cmdOut, karmadaConfig, opts)
if err != nil { if err != nil {
klog.Errorf("Error: %v", err) klog.Fatalf("Error: %v", err)
return
} }
}, },
} }