karmada-io
/
karmada
mirror of https://github.com/karmada-io/karmada.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2292 from Garrybest/pr_event 

add event error msg when failed to apply policy
This commit is contained in:
karmada-bot 2022-08-01 14:08:56 +08:00 committed by GitHub
parent 616033fc0e 8ea96c0c55
commit ad94a94dce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/detector/detector.go
View File

@ -430,7 +430,7 @@ func (d *ResourceDetector) ApplyPolicy(object *unstructured.Unstructured, object
klog.Infof("Applying policy(%s%s) for object: %s", policy.Namespace, policy.Name, objectKey) klog.Infof("Applying policy(%s%s) for object: %s", policy.Namespace, policy.Name, objectKey)
defer func() { defer func() {
if err != nil { if err != nil {
d.EventRecorder.Eventf(object, corev1.EventTypeWarning, workv1alpha2.EventReasonApplyPolicyFailed, "Apply policy(%s/%s) failed", policy.Namespace, policy.Name) d.EventRecorder.Eventf(object, corev1.EventTypeWarning, workv1alpha2.EventReasonApplyPolicyFailed, "Apply policy(%s/%s) failed: %v", policy.Namespace, policy.Name, err)
} else { } else {
d.EventRecorder.Eventf(object, corev1.EventTypeNormal, workv1alpha2.EventReasonApplyPolicySucceed, "Apply policy(%s/%s) succeed", policy.Namespace, policy.Name) d.EventRecorder.Eventf(object, corev1.EventTypeNormal, workv1alpha2.EventReasonApplyPolicySucceed, "Apply policy(%s/%s) succeed", policy.Namespace, policy.Name)
} }
@ -491,7 +491,7 @@ func (d *ResourceDetector) ApplyClusterPolicy(object *unstructured.Unstructured,
klog.Infof("Applying cluster policy(%s) for object: %s", policy.Name, objectKey) klog.Infof("Applying cluster policy(%s) for object: %s", policy.Name, objectKey)
defer func() { defer func() {
if err != nil { if err != nil {
d.EventRecorder.Eventf(object, corev1.EventTypeWarning, workv1alpha2.EventReasonApplyPolicyFailed, "Apply cluster policy(%s) failed", policy.Name) d.EventRecorder.Eventf(object, corev1.EventTypeWarning, workv1alpha2.EventReasonApplyPolicyFailed, "Apply cluster policy(%s) failed: %v", policy.Name, err)
} else { } else {
d.EventRecorder.Eventf(object, corev1.EventTypeNormal, workv1alpha2.EventReasonApplyPolicySucceed, "Apply policy(%s/%s) succeed", policy.Name) d.EventRecorder.Eventf(object, corev1.EventTypeNormal, workv1alpha2.EventReasonApplyPolicySucceed, "Apply policy(%s/%s) succeed", policy.Name)
} }