diff --git a/pkg/controllers/federatedresourcequota/federated_resource_quota_status_controller.go b/pkg/controllers/federatedresourcequota/federated_resource_quota_status_controller.go index ccfc5dd3c..cb60a43a5 100644 --- a/pkg/controllers/federatedresourcequota/federated_resource_quota_status_controller.go +++ b/pkg/controllers/federatedresourcequota/federated_resource_quota_status_controller.go @@ -26,6 +26,7 @@ import ( policyv1alpha1 "github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1" workv1alpha1 "github.com/karmada-io/karmada/pkg/apis/work/v1alpha1" + "github.com/karmada-io/karmada/pkg/events" "github.com/karmada-io/karmada/pkg/util" "github.com/karmada-io/karmada/pkg/util/helper" "github.com/karmada-io/karmada/pkg/util/names" @@ -61,20 +62,12 @@ func (c *StatusController) Reconcile(ctx context.Context, req controllerruntime. return controllerruntime.Result{}, nil } - workList := &workv1alpha1.WorkList{} - if err := c.List(ctx, workList, &client.ListOptions{ - LabelSelector: labels.SelectorFromSet(labels.Set{ - util.FederatedResourceQuotaNamespaceLabel: quota.Namespace, - util.FederatedResourceQuotaNameLabel: quota.Name, - }), - }); err != nil { - klog.Errorf("Failed to list workList created by federatedResourceQuota(%s), error: %v", req.NamespacedName.String(), err) - } - if err := c.collectQuotaStatus(quota); err != nil { klog.Errorf("Failed to collect status from works to federatedResourceQuota(%s), error: %v", req.NamespacedName.String(), err) + c.EventRecorder.Eventf(quota, corev1.EventTypeWarning, events.EventReasonCollectFederatedResourceQuotaStatusFailed, err.Error()) return controllerruntime.Result{Requeue: true}, err } + c.EventRecorder.Eventf(quota, corev1.EventTypeNormal, events.EventReasonCollectFederatedResourceQuotaStatusSucceed, "Collect status of FederatedResourceQuota(%s) succeed.", req.NamespacedName.String()) return controllerruntime.Result{}, nil } diff --git a/pkg/controllers/federatedresourcequota/federated_resource_quota_sync_controller.go b/pkg/controllers/federatedresourcequota/federated_resource_quota_sync_controller.go index 7abf57fcb..39c0f1b2c 100644 --- a/pkg/controllers/federatedresourcequota/federated_resource_quota_sync_controller.go +++ b/pkg/controllers/federatedresourcequota/federated_resource_quota_sync_controller.go @@ -22,6 +22,7 @@ import ( clusterv1alpha1 "github.com/karmada-io/karmada/pkg/apis/cluster/v1alpha1" policyv1alpha1 "github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1" workv1alpha1 "github.com/karmada-io/karmada/pkg/apis/work/v1alpha1" + "github.com/karmada-io/karmada/pkg/events" "github.com/karmada-io/karmada/pkg/util" "github.com/karmada-io/karmada/pkg/util/helper" "github.com/karmada-io/karmada/pkg/util/names" @@ -65,8 +66,10 @@ func (c *SyncController) Reconcile(ctx context.Context, req controllerruntime.Re if err := c.buildWorks(quota, clusterList.Items); err != nil { klog.Errorf("Failed to build works for federatedResourceQuota(%s), error: %v", req.NamespacedName.String(), err) + c.EventRecorder.Eventf(quota, corev1.EventTypeWarning, events.EventReasonSyncFederatedResourceQuotaFailed, err.Error()) return controllerruntime.Result{Requeue: true}, err } + c.EventRecorder.Eventf(quota, corev1.EventTypeNormal, events.EventReasonSyncFederatedResourceQuotaSucceed, "Sync works for FederatedResourceQuota(%s) succeed.", req.NamespacedName.String()) return controllerruntime.Result{}, nil } diff --git a/pkg/events/events.go b/pkg/events/events.go index f63c01709..e0e0f1292 100644 --- a/pkg/events/events.go +++ b/pkg/events/events.go @@ -66,6 +66,18 @@ const ( EventReasonDescheduleBindingSucceed = "DescheduleBindingSucceed" ) +// Define events for FederatedResourceQuota. +const ( + // EventReasonSyncFederatedResourceQuotaFailed indicates that Sync work failed. + EventReasonSyncFederatedResourceQuotaFailed = "SyncWorkFailed" + // EventReasonSyncFederatedResourceQuotaSucceed indicates that Sync work succeed. + EventReasonSyncFederatedResourceQuotaSucceed = "SyncWorkSucceed" + // EventReasonCollectFederatedResourceQuotaStatusFailed indicates that aggregate status failed. + EventReasonCollectFederatedResourceQuotaStatusFailed = "AggregateStatusFailed" + // EventReasonCollectFederatedResourceQuotaStatusSucceed indicates that aggregate status succeed. + EventReasonCollectFederatedResourceQuotaStatusSucceed = "AggregateStatusSucceed" +) + // Define events for resource templates. const ( // EventReasonApplyPolicyFailed indicates that apply policy for resource failed.