From 92bb575167bb62efc74f73bb9de9b54935d9100f Mon Sep 17 00:00:00 2001 From: changzhen Date: Wed, 2 Mar 2022 14:15:20 +0800 Subject: [PATCH 1/2] Add upgrade document about v1.0-v1.1. Signed-off-by: changzhen --- docs/upgrading/README.md | 1 + docs/upgrading/v1.0-v1.1.md | 9 +++++++++ 2 files changed, 10 insertions(+) create mode 100644 docs/upgrading/v1.0-v1.1.md diff --git a/docs/upgrading/README.md b/docs/upgrading/README.md index 0fb25a714..41bc6dc72 100644 --- a/docs/upgrading/README.md +++ b/docs/upgrading/README.md @@ -75,3 +75,4 @@ v1.1.x to v1.2.x and the available patch versions are v1.2.0, v1.2.1 and v1.2.2, ### [v0.8 to v0.9](./v0.8-v0.9.md) ### [v0.9 to v0.10](./v0.9-v0.10.md) ### [v0.10 to v1.0](./v0.10-v1.0.md) +### [v1.0 to v1.1](./v1.0-v1.1.md) diff --git a/docs/upgrading/v1.0-v1.1.md b/docs/upgrading/v1.0-v1.1.md new file mode 100644 index 000000000..8fe11496a --- /dev/null +++ b/docs/upgrading/v1.0-v1.1.md @@ -0,0 +1,9 @@ +# v1.0 to v1.1 + +Follow the [Regular Upgrading Process](./README.md). + +## Upgrading Notable Changes + +We have removed the `cluster.karmada.io` webhook point in the `validating-config` ValidatingWebhookConfiguration resource, please remember to delete it when you're upgrading. + +Please refer to [v1.1.0 Release Notes](https://github.com/karmada-io/karmada/releases/tag/v1.1.0) for more details. From 0e25d8324ee470cff3ab2a232cdcee805c927fd6 Mon Sep 17 00:00:00 2001 From: RainbowMango Date: Wed, 2 Mar 2022 15:05:30 +0800 Subject: [PATCH 2/2] Update more details upgrade information Signed-off-by: RainbowMango --- docs/upgrading/README.md | 3 +++ docs/upgrading/v1.0-v1.1.md | 36 +++++++++++++++++++++++++++++++++++- 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/docs/upgrading/README.md b/docs/upgrading/README.md index 41bc6dc72..24f743249 100644 --- a/docs/upgrading/README.md +++ b/docs/upgrading/README.md @@ -10,6 +10,9 @@ - [Upgrading Components](#upgrading-components) - [Details Upgrading Instruction](#details-upgrading-instruction) - [v0.8 to v0.9](#v08-to-v09) + - [v0.9 to v0.10](#v09-to-v010) + - [v0.10 to v1.0](#v010-to-v10) + - [v1.0 to v1.1](#v10-to-v11) diff --git a/docs/upgrading/v1.0-v1.1.md b/docs/upgrading/v1.0-v1.1.md index 8fe11496a..aaf2e26d4 100644 --- a/docs/upgrading/v1.0-v1.1.md +++ b/docs/upgrading/v1.0-v1.1.md @@ -4,6 +4,40 @@ Follow the [Regular Upgrading Process](./README.md). ## Upgrading Notable Changes -We have removed the `cluster.karmada.io` webhook point in the `validating-config` ValidatingWebhookConfiguration resource, please remember to delete it when you're upgrading. +The validation process for `Cluster` objects now has been moved from `karmada-webhook` to `karmada-aggregated-apiserver` +by [PR 1152](https://github.com/karmada-io/karmada/pull/1152), you have to remove the `Cluster` webhook configuration +from `ValidatingWebhookConfiguration`, such as: +```diff +diff --git a/artifacts/deploy/webhook-configuration.yaml b/artifacts/deploy/webhook-configuration.yaml +index 0a89ad36..f7a9f512 100644 +--- a/artifacts/deploy/webhook-configuration.yaml ++++ b/artifacts/deploy/webhook-configuration.yaml +@@ -69,20 +69,6 @@ metadata: + labels: + app: validating-config + webhooks: +- - name: cluster.karmada.io +- rules: +- - operations: ["CREATE", "UPDATE"] +- apiGroups: ["cluster.karmada.io"] +- apiVersions: ["*"] +- resources: ["clusters"] +- scope: "Cluster" +- clientConfig: +- url: https://karmada-webhook.karmada-system.svc:443/validate-cluster +- caBundle: {{caBundle}} +- failurePolicy: Fail +- sideEffects: None +- admissionReviewVersions: ["v1"] +- timeoutSeconds: 3 + - name: propagationpolicy.karmada.io + rules: + - operations: ["CREATE", "UPDATE"] +``` + +Otherwise, when joining clusters(or updating Cluster objects) the request will be rejected with following errors: +``` +Error: failed to create cluster(host) object. error: Internal error occurred: failed calling webhook "cluster.karmada.io": the server could not find the requested resource +``` Please refer to [v1.1.0 Release Notes](https://github.com/karmada-io/karmada/releases/tag/v1.1.0) for more details.