diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9dc16b0ac..110368094 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -88,6 +88,10 @@ jobs: steps: - name: checkout code uses: actions/checkout@v2 + with: + # Number of commits to fetch. 0 indicates all history for all branches and tags. + # We need to guess version via git tags. + fetch-depth: 0 - name: install Go uses: actions/setup-go@v2 with: diff --git a/cluster/images/karmada-agent/Dockerfile b/cluster/images/karmada-agent/Dockerfile index 66a87a443..fd90be122 100644 --- a/cluster/images/karmada-agent/Dockerfile +++ b/cluster/images/karmada-agent/Dockerfile @@ -1,14 +1,10 @@ -FROM golang:1.17-alpine3.15 AS builder +FROM golang:1.17 AS builder WORKDIR /go/src/github.com/karmada-io/karmada COPY . /go/src/github.com/karmada-io/karmada -ARG GO_LDFLAGS - -RUN CGO_ENABLED=0 go build \ - -ldflags "$GO_LDFLAGS" \ - -o /bin/karmada-agent \ - cmd/agent/main.go +RUN make karmada-agent +RUN mv /go/src/github.com/karmada-io/karmada/karmada-agent /bin/ FROM alpine:3.15.1 diff --git a/cluster/images/karmada-aggregated-apiserver/Dockerfile b/cluster/images/karmada-aggregated-apiserver/Dockerfile index 62f23c576..23dd500be 100644 --- a/cluster/images/karmada-aggregated-apiserver/Dockerfile +++ b/cluster/images/karmada-aggregated-apiserver/Dockerfile @@ -1,14 +1,10 @@ -FROM golang:1.17-alpine3.15 AS builder +FROM golang:1.17 AS builder WORKDIR /go/src/github.com/karmada-io/karmada COPY . /go/src/github.com/karmada-io/karmada -ARG GO_LDFLAGS - -RUN CGO_ENABLED=0 go build \ - -ldflags "${GO_LDFLAGS}" \ - -o /bin/karmada-aggregated-apiserver \ - cmd/aggregated-apiserver/main.go +RUN make karmada-aggregated-apiserver +RUN mv /go/src/github.com/karmada-io/karmada/karmada-aggregated-apiserver /bin/ FROM alpine:3.15.1 diff --git a/cluster/images/karmada-controller-manager/Dockerfile b/cluster/images/karmada-controller-manager/Dockerfile index 76ff06b4d..fb2892f79 100644 --- a/cluster/images/karmada-controller-manager/Dockerfile +++ b/cluster/images/karmada-controller-manager/Dockerfile @@ -1,14 +1,10 @@ -FROM golang:1.17-alpine3.15 AS builder +FROM golang:1.17 AS builder WORKDIR /go/src/github.com/karmada-io/karmada COPY . /go/src/github.com/karmada-io/karmada -ARG GO_LDFLAGS - -RUN CGO_ENABLED=0 go build \ - -ldflags "$GO_LDFLAGS" \ - -o /bin/karmada-controller-manager \ - cmd/controller-manager/controller-manager.go +RUN make karmada-controller-manager +RUN mv /go/src/github.com/karmada-io/karmada/karmada-controller-manager /bin/ FROM alpine:3.15.1 diff --git a/cluster/images/karmada-descheduler/Dockerfile b/cluster/images/karmada-descheduler/Dockerfile index b1de970a6..5beaf7b24 100644 --- a/cluster/images/karmada-descheduler/Dockerfile +++ b/cluster/images/karmada-descheduler/Dockerfile @@ -1,14 +1,10 @@ -FROM golang:1.17-alpine3.15 AS builder +FROM golang:1.17 AS builder WORKDIR /go/src/github.com/karmada-io/karmada COPY . /go/src/github.com/karmada-io/karmada -ARG GO_LDFLAGS - -RUN CGO_ENABLED=0 go build \ - -ldflags "$GO_LDFLAGS" \ - -o /bin/karmada-descheduler \ - cmd/descheduler/main.go +RUN make karmada-descheduler +RUN mv /go/src/github.com/karmada-io/karmada/karmada-descheduler /bin/ FROM alpine:3.15.1 diff --git a/cluster/images/karmada-interpreter-webhook-example/Dockerfile b/cluster/images/karmada-interpreter-webhook-example/Dockerfile index c8a311659..558f93b55 100644 --- a/cluster/images/karmada-interpreter-webhook-example/Dockerfile +++ b/cluster/images/karmada-interpreter-webhook-example/Dockerfile @@ -1,14 +1,10 @@ -FROM golang:1.17-alpine3.15 AS builder +FROM golang:1.17 AS builder WORKDIR /go/src/github.com/karmada-io/karmada COPY . /go/src/github.com/karmada-io/karmada -ARG GO_LDFLAGS - -RUN CGO_ENABLED=0 go build \ - -ldflags "$GO_LDFLAGS" \ - -o /bin/karmada-interpreter-webhook-example \ - examples/customresourceinterpreter/webhook/main.go +RUN make karmada-interpreter-webhook-example +RUN mv /go/src/github.com/karmada-io/karmada/karmada-interpreter-webhook-example /bin/ FROM alpine:3.15.1 diff --git a/cluster/images/karmada-scheduler-estimator/Dockerfile b/cluster/images/karmada-scheduler-estimator/Dockerfile index b59beb224..8b665c901 100644 --- a/cluster/images/karmada-scheduler-estimator/Dockerfile +++ b/cluster/images/karmada-scheduler-estimator/Dockerfile @@ -1,14 +1,10 @@ -FROM golang:1.17-alpine3.15 AS builder +FROM golang:1.17 AS builder WORKDIR /go/src/github.com/karmada-io/karmada COPY . /go/src/github.com/karmada-io/karmada -ARG GO_LDFLAGS - -RUN CGO_ENABLED=0 go build \ - -ldflags "$GO_LDFLAGS" \ - -o /bin/karmada-scheduler-estimator \ - cmd/scheduler-estimator/main.go +RUN make karmada-scheduler-estimator +RUN mv /go/src/github.com/karmada-io/karmada/karmada-scheduler-estimator /bin/ FROM alpine:3.15.1 diff --git a/cluster/images/karmada-scheduler/Dockerfile b/cluster/images/karmada-scheduler/Dockerfile index a97bfb186..6a01f9832 100644 --- a/cluster/images/karmada-scheduler/Dockerfile +++ b/cluster/images/karmada-scheduler/Dockerfile @@ -1,14 +1,10 @@ -FROM golang:1.17-alpine3.15 AS builder +FROM golang:1.17 AS builder WORKDIR /go/src/github.com/karmada-io/karmada COPY . /go/src/github.com/karmada-io/karmada -ARG GO_LDFLAGS - -RUN CGO_ENABLED=0 go build \ - -ldflags "$GO_LDFLAGS" \ - -o /bin/karmada-scheduler \ - cmd/scheduler/main.go +RUN make karmada-scheduler +RUN mv /go/src/github.com/karmada-io/karmada/karmada-scheduler /bin/ FROM alpine:3.15.1 diff --git a/cluster/images/karmada-webhook/Dockerfile b/cluster/images/karmada-webhook/Dockerfile index d8fe8095b..fb14b314b 100644 --- a/cluster/images/karmada-webhook/Dockerfile +++ b/cluster/images/karmada-webhook/Dockerfile @@ -1,14 +1,10 @@ -FROM golang:1.17-alpine3.15 AS builder +FROM golang:1.17 AS builder WORKDIR /go/src/github.com/karmada-io/karmada COPY . /go/src/github.com/karmada-io/karmada -ARG GO_LDFLAGS - -RUN CGO_ENABLED=0 go build \ - -ldflags "$GO_LDFLAGS" \ - -o /bin/karmada-webhook \ - cmd/webhook/main.go +RUN make karmada-webhook +RUN mv /go/src/github.com/karmada-io/karmada/karmada-webhook /bin/ FROM alpine:3.15.1 diff --git a/hack/docker.sh b/hack/docker.sh index c201ab044..76e65bd43 100755 --- a/hack/docker.sh +++ b/hack/docker.sh @@ -11,11 +11,10 @@ source "${REPO_ROOT}/hack/util.sh" REGISTRY=${REGISTRY:-"swr.ap-southeast-1.myhuaweicloud.com/karmada"} VERSION=${VERSION:="unknown"} -GO_LDFLAGS=$(util::get_GO_LDFLAGS) function build_images() { local target="$1" - docker build --build-arg GO_LDFLAGS="${GO_LDFLAGS}" -t ${REGISTRY}/${target}:${VERSION} -f ${REPO_ROOT}/cluster/images/${target}/Dockerfile ${REPO_ROOT} + docker build -t ${REGISTRY}/${target}:${VERSION} -f ${REPO_ROOT}/cluster/images/${target}/Dockerfile ${REPO_ROOT} } build_images $@