From d33ae3818c018ca77b83904d52bf2d4de68624e1 Mon Sep 17 00:00:00 2001 From: gy95 <36992787+gy95@users.noreply.github.com> Date: Sun, 16 May 2021 19:01:11 +0800 Subject: [PATCH] fix blank lines of import packages and repeated import problems (#337) Signed-off-by: gy95 --- cmd/agent/app/options/options.go | 1 - pkg/controllers/cluster/cluster_controller.go | 3 +-- pkg/util/objectwatcher/objectwatcher.go | 7 +++---- test/e2e/namespace_test.go | 1 - 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/cmd/agent/app/options/options.go b/cmd/agent/app/options/options.go index 38b6c3390..01f0b6b54 100644 --- a/cmd/agent/app/options/options.go +++ b/cmd/agent/app/options/options.go @@ -4,7 +4,6 @@ import ( "time" "github.com/spf13/pflag" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" ) diff --git a/pkg/controllers/cluster/cluster_controller.go b/pkg/controllers/cluster/cluster_controller.go index 1fb9c002b..a2c47df82 100644 --- a/pkg/controllers/cluster/cluster_controller.go +++ b/pkg/controllers/cluster/cluster_controller.go @@ -5,7 +5,6 @@ import ( "fmt" corev1 "k8s.io/api/core/v1" - "k8s.io/apimachinery/pkg/api/errors" apierrors "k8s.io/apimachinery/pkg/api/errors" v1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/types" @@ -40,7 +39,7 @@ func (c *Controller) Reconcile(ctx context.Context, req controllerruntime.Reques cluster := &v1alpha1.Cluster{} if err := c.Client.Get(context.TODO(), req.NamespacedName, cluster); err != nil { // The resource may no longer exist, in which case we stop processing. - if errors.IsNotFound(err) { + if apierrors.IsNotFound(err) { return controllerruntime.Result{}, nil } diff --git a/pkg/util/objectwatcher/objectwatcher.go b/pkg/util/objectwatcher/objectwatcher.go index 9ca591d5d..62cd667cf 100644 --- a/pkg/util/objectwatcher/objectwatcher.go +++ b/pkg/util/objectwatcher/objectwatcher.go @@ -10,7 +10,6 @@ import ( apierrors "k8s.io/apimachinery/pkg/api/errors" "k8s.io/apimachinery/pkg/api/meta" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - v1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" "k8s.io/klog/v2" "sigs.k8s.io/controller-runtime/pkg/client" @@ -67,7 +66,7 @@ func (o *objectWatcherImpl) Create(cluster *v1alpha1.Cluster, desireObj *unstruc return err } - clusterObj, err := dynamicClusterClient.DynamicClientSet.Resource(gvr).Namespace(desireObj.GetNamespace()).Create(context.TODO(), desireObj, v1.CreateOptions{}) + clusterObj, err := dynamicClusterClient.DynamicClientSet.Resource(gvr).Namespace(desireObj.GetNamespace()).Create(context.TODO(), desireObj, metav1.CreateOptions{}) if err != nil { if apierrors.IsAlreadyExists(err) { return nil @@ -101,7 +100,7 @@ func (o *objectWatcherImpl) Update(cluster *v1alpha1.Cluster, desireObj, cluster return err } - resource, err := dynamicClusterClient.DynamicClientSet.Resource(gvr).Namespace(desireObj.GetNamespace()).Update(context.TODO(), desireObj, v1.UpdateOptions{}) + resource, err := dynamicClusterClient.DynamicClientSet.Resource(gvr).Namespace(desireObj.GetNamespace()).Update(context.TODO(), desireObj, metav1.UpdateOptions{}) if err != nil { klog.Errorf("Failed to update resource %v/%v, err is %v ", desireObj.GetNamespace(), desireObj.GetName(), err) return err @@ -127,7 +126,7 @@ func (o *objectWatcherImpl) Delete(cluster *v1alpha1.Cluster, desireObj *unstruc return err } - err = dynamicClusterClient.DynamicClientSet.Resource(gvr).Namespace(desireObj.GetNamespace()).Delete(context.TODO(), desireObj.GetName(), v1.DeleteOptions{}) + err = dynamicClusterClient.DynamicClientSet.Resource(gvr).Namespace(desireObj.GetNamespace()).Delete(context.TODO(), desireObj.GetName(), metav1.DeleteOptions{}) if apierrors.IsNotFound(err) { err = nil } diff --git a/test/e2e/namespace_test.go b/test/e2e/namespace_test.go index 4ad323ceb..10e1d2d66 100644 --- a/test/e2e/namespace_test.go +++ b/test/e2e/namespace_test.go @@ -7,7 +7,6 @@ import ( "github.com/onsi/ginkgo" "github.com/onsi/gomega" - "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/util/rand"