diff --git a/.golangci.yml b/.golangci.yml index d6dd01fef..e96d7abcd 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -42,6 +42,7 @@ linters: - unused - varcheck # other linters supported by golangci-lint. + - gci - gocyclo - gosec - whitespace @@ -53,6 +54,11 @@ linters-settings: gocyclo: # minimal cyclomatic complexity to report min-complexity: 15 + gci: + sections: + - Standard + - Default + - Prefix(github.com/karmada-io/karmada) issues: # The list of ids of default excludes to include or disable. By default it's empty. @@ -62,3 +68,12 @@ issues: - EXC0012 - EXC0013 - EXC0014 + exclude-rules: + # Exclude 'cmd/agent/main.go' and 'cmd/controller-manager/controller-manager.go' + # because 'sigs.k8s.io/controller-runtime/pkg/metrics' package should be set before 'k8s.io/apiserver/pkg/server' . + - path: cmd/agent/main.go + linters: + - gci + - path: cmd/controller-manager/controller-manager.go + linters: + - gci diff --git a/pkg/karmadactl/cmdinit/kubernetes/rbac.go b/pkg/karmadactl/cmdinit/kubernetes/rbac.go index fc55cc85f..fe4084ac9 100644 --- a/pkg/karmadactl/cmdinit/kubernetes/rbac.go +++ b/pkg/karmadactl/cmdinit/kubernetes/rbac.go @@ -1,9 +1,9 @@ package kubernetes import ( - "github.com/karmada-io/karmada/pkg/karmadactl/cmdinit/utils" - rbacv1 "k8s.io/api/rbac/v1" + + "github.com/karmada-io/karmada/pkg/karmadactl/cmdinit/utils" ) // CreateControllerManagerRBAC karmada-controller-manager ClusterRole and ClusterRoleBinding