From dbb56be9bc87e5109fca95faba7f58154a3b4e1c Mon Sep 17 00:00:00 2001 From: Kevin Wang Date: Mon, 30 Nov 2020 20:01:35 +0800 Subject: [PATCH] Apply suggestions from code review --- README.md | 13 +++++++------ samples/nginx/deployment.yaml | 2 +- samples/nginx/propagationpolicy.yaml | 2 +- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 0f0b08c5f..b85d3d67a 100644 --- a/README.md +++ b/README.md @@ -58,7 +58,7 @@ cd karmada 3. Install karmada. ``` -export KUBECONFIG=/root/.kube/host.config +export KUBECONFIG=/root/.kube/karmada.config hack/local-up-karmada.sh ``` @@ -73,14 +73,14 @@ kubectl get pods -n karmada-system 1. Create **member cluster** for attaching it to karmada. ``` -hack/create-cluster.sh member /root/.kube/member.config +hack/create-cluster.sh member-cluster-1 /root/.kube/membercluster1.config ``` 2. Join member cluster to karmada using karmadactl. ``` make karmadactl -./karmadactl join member --member-cluster-kubeconfig=/root/.kube/member.config +./karmadactl join member-cluster-1 --member-cluster-kubeconfig=/root/.kube/membercluster1.config ``` 3. Verify member cluster is Joined to karmada successfully. @@ -94,19 +94,20 @@ kubectl get membercluster -n karmada-cluster 1. Create nginx deployment in karmada. ``` +export KUBECONFIG=/root/.kube/karmada.config kubectl create -f samples/nginx/deployment.yaml ``` 2. Create PropagationPolicy that will propagate nginx to member cluster. ``` +export KUBECONFIG=/root/.kube/karmada.config kubectl create -f samples/nginx/propagationpolicy.yaml ``` -3. Verify the nginx is deployed successfully in **member cluster**. +3. Verify the nginx is deployed successfully in **member-cluster-1**. ``` -export KUBECONFIG=/root/.kube/member.config +export KUBECONFIG=/root/.kube/membercluster1.config kubectl describe deploy nginx ``` - diff --git a/samples/nginx/deployment.yaml b/samples/nginx/deployment.yaml index ec5147b02..a07f70301 100644 --- a/samples/nginx/deployment.yaml +++ b/samples/nginx/deployment.yaml @@ -16,4 +16,4 @@ spec: spec: containers: - image: nginx - name: nginx \ No newline at end of file + name: nginx diff --git a/samples/nginx/propagationpolicy.yaml b/samples/nginx/propagationpolicy.yaml index 74c5778b7..f1348aa28 100644 --- a/samples/nginx/propagationpolicy.yaml +++ b/samples/nginx/propagationpolicy.yaml @@ -13,4 +13,4 @@ spec: placement: clusterAffinity: clusterNames: - - member \ No newline at end of file + - member