karmada-io
/
karmada
mirror of https://github.com/karmada-io/karmada.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4721 from chaosi-zju/hpasyncerv2 

fix deployment replicas syncer in case deployment status changed before label added
This commit is contained in:
karmada-bot 2024-03-20 15:02:49 +08:00 committed by GitHub
parent 2d31561dbe 3012c808f8
commit dbb82bebd2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/controllers/deploymentreplicassyncer/deployment_replicas_syncer_controller.go
View File

@ -57,6 +57,13 @@ var predicateFunc = predicate.Funcs{
return false return false
} }
// if old deployment is not labeled `retain-replicas`, but new is labeled, reconcile is needed.
// in case of deployment status changed before `retain-replicas` labeled.
oldRetainReplicasLabel := util.GetLabelValue(oldObj.GetLabels(), util.RetainReplicasLabel)
if oldRetainReplicasLabel != util.RetainReplicasValue {
return true
}
if oldObj.Spec.Replicas == nil || newObj.Spec.Replicas == nil { if oldObj.Spec.Replicas == nil || newObj.Spec.Replicas == nil {
klog.Errorf("spec.replicas field unexpectedly become nil: %+v, %+v", oldObj.Spec.Replicas, newObj.Spec.Replicas) klog.Errorf("spec.replicas field unexpectedly become nil: %+v, %+v", oldObj.Spec.Replicas, newObj.Spec.Replicas)
return false return false