karmada-io
/
karmada
mirror of https://github.com/karmada-io/karmada.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4522 from helen-frank/fix/defer_runlock 

defer RUnlock
This commit is contained in:
karmada-bot 2024-01-10 17:33:34 +08:00 committed by GitHub
parent 560e2cbe11 2397af5f24
commit e857d1f95e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/util/fedinformer/typedmanager/single-cluster-manager.go
View File

@ -205,13 +205,13 @@ func (s *singleClusterInformerManagerImpl) Lister(resource schema.GroupVersionRe
s.lock.Unlock() s.lock.Unlock()
s.lock.RLock() s.lock.RLock()
defer s.lock.RUnlock()
if resourceTransformFunc, ok := s.transformFuncs[resource]; ok && !s.isInformerStarted(resource) { if resourceTransformFunc, ok := s.transformFuncs[resource]; ok && !s.isInformerStarted(resource) {
err = resourceInformer.Informer().SetTransform(resourceTransformFunc) err = resourceInformer.Informer().SetTransform(resourceTransformFunc)
if err != nil { if err != nil {
return nil, err return nil, err
} }
} }
s.lock.RUnlock()
if resource == nodeGVR { if resource == nodeGVR {
return s.informerFactory.Core().V1().Nodes().Lister(), nil return s.informerFactory.Core().V1().Nodes().Lister(), nil
@ -233,13 +233,13 @@ func (s *singleClusterInformerManagerImpl) appendHandler(resource schema.GroupVe
func (s *singleClusterInformerManagerImpl) Start() { func (s *singleClusterInformerManagerImpl) Start() {
s.lock.Lock() s.lock.Lock()
defer s.lock.Unlock()
s.informerFactory.Start(s.ctx.Done()) s.informerFactory.Start(s.ctx.Done())
for resource := range s.informers { for resource := range s.informers {
if _, exist := s.startedInformers[resource]; !exist { if _, exist := s.startedInformers[resource]; !exist {
s.startedInformers[resource] = struct{}{} s.startedInformers[resource] = struct{}{}
} }
} }
s.lock.Unlock()
} }
func (s *singleClusterInformerManagerImpl) Stop() { func (s *singleClusterInformerManagerImpl) Stop() {