From e8a6e50a84dbe3bcc539f3d7efec649558e8121b Mon Sep 17 00:00:00 2001 From: "xin.li" Date: Sun, 5 Feb 2023 18:07:59 +0800 Subject: [PATCH] [ut] improve ut coverage for node.go Signed-off-by: xin.li --- .../cmdinit/kubernetes/node_test.go | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/pkg/karmadactl/cmdinit/kubernetes/node_test.go b/pkg/karmadactl/cmdinit/kubernetes/node_test.go index 04a667461..d9e5f426b 100644 --- a/pkg/karmadactl/cmdinit/kubernetes/node_test.go +++ b/pkg/karmadactl/cmdinit/kubernetes/node_test.go @@ -169,6 +169,7 @@ func TestCommandInitOption_AddNodeSelectorLabels(t *testing.T) { name string option CommandInitOption status corev1.ConditionStatus + spec corev1.NodeSpec wantErr bool }{ { @@ -177,6 +178,7 @@ func TestCommandInitOption_AddNodeSelectorLabels(t *testing.T) { KubeClientSet: fake.NewSimpleClientset(), }, status: corev1.ConditionTrue, + spec: corev1.NodeSpec{}, wantErr: false, }, { @@ -185,6 +187,22 @@ func TestCommandInitOption_AddNodeSelectorLabels(t *testing.T) { KubeClientSet: fake.NewSimpleClientset(), }, status: corev1.ConditionFalse, + spec: corev1.NodeSpec{}, + wantErr: true, + }, + { + name: "there is taint node", + option: CommandInitOption{ + KubeClientSet: fake.NewSimpleClientset(), + }, + status: corev1.ConditionTrue, + spec: corev1.NodeSpec{ + Taints: []corev1.Taint{ + { + Effect: corev1.TaintEffectNoSchedule, + }, + }, + }, wantErr: true, }, } @@ -197,6 +215,7 @@ func TestCommandInitOption_AddNodeSelectorLabels(t *testing.T) { {Type: corev1.NodeReady, Status: tt.status}, }, }, + Spec: tt.spec, }, metav1.CreateOptions{}) if err != nil { t.Errorf("create node error: %v", err)