karmada-io
/
karmada
mirror of https://github.com/karmada-io/karmada.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #837 from wawa0210/refactor-executespace-event 

refactor execute space event
This commit is contained in:
karmada-bot 2021-10-20 12:07:06 +08:00 committed by GitHub
parent a6011ecde6 854cac6e72
commit e9f4bdeb94
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/apis/cluster/v1alpha1/events.go Normal file
View File

@ -0,0 +1,9 @@
package v1alpha1
// Define events for execute space objects.
const (
// EventReasonCreateExecutionSpaceFailed indicates that create execution space failed.
EventReasonCreateExecutionSpaceFailed = "CreateExecutionSpaceFailed"
// EventReasonRemoveExecutionSpaceFailed indicates that remove execution space failed.
EventReasonRemoveExecutionSpaceFailed = "RemoveExecutionSpaceFailed"
)

8
pkg/controllers/cluster/cluster_controller.go
View File

@ -33,9 +33,7 @@ const (
// sleep between retrying cluster health updates. // sleep between retrying cluster health updates.
MonitorRetrySleepTime = 20 * time.Millisecond MonitorRetrySleepTime = 20 * time.Millisecond
// HealthUpdateRetry controls the number of retries of writing cluster health update. // HealthUpdateRetry controls the number of retries of writing cluster health update.
HealthUpdateRetry = 5 HealthUpdateRetry = 5
eventReasonCreateExecutionNamespaceFailed = "CreateExecutionNamespaceFailed"
eventReasonRemoveExecutionNamespaceFailed = "RemoveExecutionNamespaceFailed"
) )
// Controller is to sync Cluster. // Controller is to sync Cluster.
@ -115,7 +113,7 @@ func (c *Controller) syncCluster(cluster *clusterv1alpha1.Cluster) (controllerru
// create execution space // create execution space
err := c.createExecutionSpace(cluster) err := c.createExecutionSpace(cluster)
if err != nil { if err != nil {
c.EventRecorder.Event(cluster, corev1.EventTypeWarning, fmt.Sprintf("Failed %s", eventReasonRemoveExecutionNamespaceFailed), err.Error()) c.EventRecorder.Event(cluster, corev1.EventTypeWarning, fmt.Sprintf("Failed %s", clusterv1alpha1.EventReasonRemoveExecutionSpaceFailed), err.Error())
return controllerruntime.Result{Requeue: true}, err return controllerruntime.Result{Requeue: true}, err
} }
@ -130,7 +128,7 @@ func (c *Controller) removeCluster(cluster *clusterv1alpha1.Cluster) (controller
} }
if err != nil { if err != nil {
klog.Errorf("Failed to remove execution space %v, err is %v", cluster.Name, err) klog.Errorf("Failed to remove execution space %v, err is %v", cluster.Name, err)
c.EventRecorder.Event(cluster, corev1.EventTypeWarning, fmt.Sprintf("Failed %s", eventReasonCreateExecutionNamespaceFailed), err.Error()) c.EventRecorder.Event(cluster, corev1.EventTypeWarning, fmt.Sprintf("Failed %s", clusterv1alpha1.EventReasonCreateExecutionSpaceFailed), err.Error())
return controllerruntime.Result{Requeue: true}, err return controllerruntime.Result{Requeue: true}, err
} }