fix: Use a user with permissions for ghcr login always (#2465)

Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>

.github/workflows/pr-e2e.yml

@@ -50,9 +50,12 @@ jobs:
       - name: Login to GitHub Container Registry
         uses: docker/login-action@v1
         with:
+          # Username used to log in to a Docker registry. If not set then no login will occur
+          username: ${{ github.repository_owner }}
+          # Password or personal access token used to log in to a Docker registry. If not set then no login will occur
+          password: ${{ secrets.GHCR_AUTH_PAT }}
+          # Server address of Docker registry. If not set then will default to Docker Hub
           registry: ghcr.io
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Publish on GitHub Container Registry
         run: make publish

.github/workflows/upgrade-validation-template.yml

@@ -13,9 +13,12 @@ jobs:
     - name: Login to GitHub Container Registry
       uses: docker/login-action@v1
       with:
+        # Username used to log in to a Docker registry. If not set then no login will occur
+        username: ${{ github.repository_owner }}
+        # Password or personal access token used to log in to a Docker registry. If not set then no login will occur
+        password: ${{ secrets.GHCR_AUTH_PAT }}
+        # Server address of Docker registry. If not set then will default to Docker Hub
         registry: ghcr.io
-        username: ${{ github.actor }}
-        password: ${{ secrets.GITHUB_TOKEN }}
 
     - name: Build current version
       run : make publish

CHANGELOG.md

@@ -44,7 +44,7 @@
 
 ### Other
 
-- **General:** Add workflow for testing breaking changes on CRDs (`Scaled{Object|Job}`) ([#2450](https://github.com/kedacore/keda/pull/2450))
+- **General:** Add workflow for testing breaking changes on CRDs (`Scaled{Object|Job}`) ([#2450](https://github.com/kedacore/keda/pull/2450))|([#2465](https://github.com/kedacore/keda/pull/2465))
 
 ## v2.5.0