knative
/
caching
mirror of https://github.com/knative/caching.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix the govet error (#318) 

as can be seen here: https://github.com/knative/caching/pull/317/checks?check_run_id=1026849591
This commit is contained in:
Victor Agababov 2020-08-25 09:41:48 -07:00 committed by GitHub
parent bb62d94135
commit 0ebbd5354e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/apis/caching/v1alpha1/image_types.go
View File

@ -155,7 +155,9 @@ func (rs *ImageStatus) SetCondition(new *ImageCondition) {
}
}
}
new.LastTransitionTime = apis.VolatileTime{metav1.NewTime(time.Now())}
new.LastTransitionTime = apis.VolatileTime{
Inner: metav1.NewTime(time.Now()),
}
conditions = append(conditions, *new)
// Deterministically order the conditions
sort.Slice(conditions, func(i, j int) bool { return conditions[i].Type < conditions[j].Type })

4
pkg/apis/caching/v1alpha1/image_types_test.go
View File

@ -157,7 +157,9 @@ func TestImageConditions(t *testing.T) {
// things are not updated.
bar = rev.Status.GetCondition("Bar")
bar2 := bar.DeepCopy()
bar2.LastTransitionTime = apis.VolatileTime{metav1.NewTime(time.Unix(1234, 0))}
bar2.LastTransitionTime = apis.VolatileTime{
Inner: metav1.NewTime(time.Unix(1234, 0)),
}
rev.Status.SetCondition(bar2)
got, want := rev.Status.GetCondition("Bar"), bar