From 1ee47505018d2d1b7f7192650e8ec229fcecf445 Mon Sep 17 00:00:00 2001 From: knative-automation Date: Wed, 6 Jan 2021 18:17:36 -0800 Subject: [PATCH] Update common github actions (#413) Signed-off-by: Knative Automation --- .github/workflows/knative-releasability.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/knative-releasability.yaml b/.github/workflows/knative-releasability.yaml index ecfd542a..cecf0a52 100644 --- a/.github/workflows/knative-releasability.yaml +++ b/.github/workflows/knative-releasability.yaml @@ -50,6 +50,9 @@ jobs: if [[ "${{ github.event.inputs.slackChannel }}" != "" ]]; then echo "SLACK_CHANNEL=${{ github.event.inputs.slackChannel }}" >> $GITHUB_ENV fi + if [[ "${{ secrets.SLACK_WEBHOOK }}" != "" ]]; then + echo "SLACK_WEBHOOK=exists" >> $GITHUB_ENV + fi - name: Set up Go 1.15.x uses: actions/setup-go@v2 @@ -142,7 +145,8 @@ jobs: echo 'SLACK_TITLE=Releasability for ${{ github.repository }} @ ${{ env.RELEASE }} is NO-GO!' >> $GITHUB_ENV - name: Post status to Slack - if: ${{ secrets.SLACK_WEBHOOK != '' && steps.exists.outputs.release-branch == 'false' }} + # Note: using env.SLACK_WEBHOOK here because secrets are not allowed in the if block. + if: env.SLACK_WEBHOOK != '' && steps.exists.outputs.release-branch == 'false' uses: rtCamp/action-slack-notify@v2.1.0 env: SLACK_ICON: http://github.com/knative.png?size=48