Auto-update dependencies (#174)

Produced via:
  `dep ensure -update knative.dev/test-infra knative.dev/pkg`
/assign n3wscott
/cc n3wscott

Gopkg.lock

@@ -931,7 +931,7 @@
 
 [[projects]]
   branch = "master"
-  digest = "1:39b9c37fd5c6e531b1a2e740ab2ed2fbe237b3f142255fbd8ebae905a957d942"
+  digest = "1:fc3b67f0e6eb15b4137fe05cd4e9c9541fb743cab8f0ecc2ded1026c78d743ae"
   name = "knative.dev/pkg"
   packages = [
     "apis",
@@ -950,7 +950,7 @@
     "metrics/metricskey",
   ]
   pruneopts = "T"
-  revision = "169ef0797c1f7e548574e6aee289002c0f22dc0a"
+  revision = "a43659c656a7ddc2a04e74b7e5b8ca3a5d4a04ed"
 
 [[projects]]
   branch = "master"
@@ -961,7 +961,7 @@
     "tools/dep-collector",
   ]
   pruneopts = "UT"
-  revision = "c6031e2873d748338362bccaab46d2d347329d58"
+  revision = "67effe44de5d3500046a77220f90cba376b2c104"
 
 [[projects]]
   digest = "1:8730e0150dfb2b7e173890c8b9868e7a273082ef8e39f4940e3506a481cf895c"

vendor/knative.dev/pkg/Gopkg.lock

@@ -857,10 +857,11 @@
   version = "v2.2.4"
 
 [[projects]]
-  digest = "1:2b55f57d7b6d9f0f23478f2432b03273073f1bf93aed18620472e7117eb4451e"
+  digest = "1:d77b48cc0ea74f3edbc8e0515a0ce2fa2154eb414137dd4fb5a642a73296d403"
   name = "k8s.io/api"
   packages = [
     "admission/v1beta1",
+    "admissionregistration/v1",
     "admissionregistration/v1beta1",
     "apps/v1",
     "apps/v1beta1",
@@ -880,6 +881,7 @@
     "coordination/v1",
     "coordination/v1beta1",
     "core/v1",
+    "discovery/v1alpha1",
     "events/v1beta1",
     "extensions/v1beta1",
     "networking/v1",
@@ -899,32 +901,37 @@
     "storage/v1beta1",
   ]
   pruneopts = "NUT"
-  revision = "3544db3b9e4494309507e02eced5cd9dcff47e6a"
+  revision = "2a24ef1ce092b529249c747df24d66a55fe97ad0"
-  version = "kubernetes-1.15.3"
+  version = "kubernetes-1.16.4"
 
 [[projects]]
-  digest = "1:efa94711dcabead5fd1dba5e3fccaa735201223a3ae55bb203a8741ad719e4b4"
+  digest = "1:afd0dcc3994c4cb27d6322160bae23e602ccca2050b18b8d0f178224acd71c04"
   name = "k8s.io/apiextensions-apiserver"
   packages = [
     "pkg/apis/apiextensions",
+    "pkg/apis/apiextensions/v1",
     "pkg/apis/apiextensions/v1beta1",
     "pkg/client/clientset/clientset",
     "pkg/client/clientset/clientset/fake",
     "pkg/client/clientset/clientset/scheme",
+    "pkg/client/clientset/clientset/typed/apiextensions/v1",
+    "pkg/client/clientset/clientset/typed/apiextensions/v1/fake",
     "pkg/client/clientset/clientset/typed/apiextensions/v1beta1",
     "pkg/client/clientset/clientset/typed/apiextensions/v1beta1/fake",
     "pkg/client/informers/externalversions",
     "pkg/client/informers/externalversions/apiextensions",
+    "pkg/client/informers/externalversions/apiextensions/v1",
     "pkg/client/informers/externalversions/apiextensions/v1beta1",
     "pkg/client/informers/externalversions/internalinterfaces",
+    "pkg/client/listers/apiextensions/v1",
     "pkg/client/listers/apiextensions/v1beta1",
   ]
   pruneopts = "NUT"
-  revision = "0dbe462fe92dfa8b56cc9facf0658a17d0c70fc5"
+  revision = "bbf2aa1c9d0f69788f9cbd29ad5520574f91133c"
-  version = "kubernetes-1.15.3"
+  version = "kubernetes-1.16.4"
 
 [[projects]]
-  digest = "1:ba294a7c42266533c2f109a7bff93f8bd2ec87d4406fee1bbde67c1d649d08e4"
+  digest = "1:e00f750d45d512f0e7bf9c2c566e3cb13233b0c035a2b89d8c096dfc98e2e1c7"
   name = "k8s.io/apimachinery"
   packages = [
     "pkg/api/equality",
@@ -975,11 +982,11 @@
     "third_party/forked/golang/reflect",
   ]
   pruneopts = "NUT"
-  revision = "f2f3a405f61d6c2cdc0d00687c1b5d90de91e9f0"
+  revision = "72ed19daf4bb788ae595ae4103c404cb0fa09c84"
-  version = "kubernetes-1.15.3"
+  version = "kubernetes-1.16.4"
 
 [[projects]]
-  digest = "1:f3d53e8c6ee1c0312bbf66e5a98aee44288388a19e8dc164d8beeeae0b32a925"
+  digest = "1:b03297e45cd203dee7e9449141555d3973d04d5323ece6b4e20562b80185767e"
   name = "k8s.io/client-go"
   packages = [
     "discovery",
@@ -988,6 +995,7 @@
     "dynamic/fake",
     "informers",
     "informers/admissionregistration",
+    "informers/admissionregistration/v1",
     "informers/admissionregistration/v1beta1",
     "informers/apps",
     "informers/apps/v1",
@@ -1010,6 +1018,8 @@
     "informers/coordination/v1beta1",
     "informers/core",
     "informers/core/v1",
+    "informers/discovery",
+    "informers/discovery/v1alpha1",
     "informers/events",
     "informers/events/v1beta1",
     "informers/extensions",
@@ -1040,6 +1050,8 @@
     "kubernetes",
     "kubernetes/fake",
     "kubernetes/scheme",
+    "kubernetes/typed/admissionregistration/v1",
+    "kubernetes/typed/admissionregistration/v1/fake",
     "kubernetes/typed/admissionregistration/v1beta1",
     "kubernetes/typed/admissionregistration/v1beta1/fake",
     "kubernetes/typed/apps/v1",
@@ -1078,6 +1090,8 @@
     "kubernetes/typed/coordination/v1beta1/fake",
     "kubernetes/typed/core/v1",
     "kubernetes/typed/core/v1/fake",
+    "kubernetes/typed/discovery/v1alpha1",
+    "kubernetes/typed/discovery/v1alpha1/fake",
     "kubernetes/typed/events/v1beta1",
     "kubernetes/typed/events/v1beta1/fake",
     "kubernetes/typed/extensions/v1beta1",
@@ -1112,6 +1126,7 @@
     "kubernetes/typed/storage/v1alpha1/fake",
     "kubernetes/typed/storage/v1beta1",
     "kubernetes/typed/storage/v1beta1/fake",
+    "listers/admissionregistration/v1",
     "listers/admissionregistration/v1beta1",
     "listers/apps/v1",
     "listers/apps/v1beta1",
@@ -1127,6 +1142,7 @@
     "listers/coordination/v1",
     "listers/coordination/v1beta1",
     "listers/core/v1",
+    "listers/discovery/v1alpha1",
     "listers/events/v1beta1",
     "listers/extensions/v1beta1",
     "listers/networking/v1",
@@ -1176,11 +1192,11 @@
     "util/workqueue",
   ]
   pruneopts = "NUT"
-  revision = "e14f31a72a77f7aa82a95eaf542d1194fb027d04"
+  revision = "20ea64f01e4d4026bce06d61d697368390aeda4e"
-  version = "kubernetes-1.15.3"
+  version = "kubernetes-1.16.4"
 
 [[projects]]
-  digest = "1:f41480fd8c5f54b13326ee0f2ee398d5734789b790dbc4db57f9b08a0d63139a"
+  digest = "1:a6aa236db5d07dff9ea1160ef316b17e131d2b1b2ad7d177431206bf389d241e"
   name = "k8s.io/code-generator"
   packages = [
     "cmd/client-gen",
@@ -1205,8 +1221,8 @@
     "pkg/util",
   ]
   pruneopts = "T"
-  revision = "18da4a14b22b17d2fa761e50037fabfbacec225b"
+  revision = "8e001e5d18949be7e823ccb9cfe9b60026e7bda0"
-  version = "kubernetes-1.15.3"
+  version = "kubernetes-1.16.4"
 
 [[projects]]
   branch = "master"

vendor/knative.dev/pkg/Gopkg.toml

@@ -17,23 +17,23 @@ required = [
 
 [[constraint]]
   name = "k8s.io/api"
-  version = "kubernetes-1.15.3"
+  version = "kubernetes-1.16.4"
 
 [[override]]
   name = "k8s.io/apiextensions-apiserver"
-  version = "kubernetes-1.15.3"
+  version = "kubernetes-1.16.4"
 
 [[constraint]]
   name = "k8s.io/apimachinery"
-  version = "kubernetes-1.15.3"
+  version = "kubernetes-1.16.4"
 
 [[constraint]]
   name = "k8s.io/client-go"
-  version = "kubernetes-1.15.3"
+  version = "kubernetes-1.16.4"
 
 [[constraint]]
   name = "k8s.io/code-generator"
-  version = "kubernetes-1.15.3"
+  version = "kubernetes-1.16.4"
 
 [[constraint]]
   name = "github.com/gogo/protobuf"

vendor/knative.dev/pkg/apis/condition_set.go

@@ -52,6 +52,9 @@ type ConditionManager interface {
 	// set to true.
 	IsHappy() bool
 
+	// GetTopLevelCondition finds and returns the top level Condition (happy Condition).
+	GetTopLevelCondition() *Condition
+
 	// GetCondition finds and returns the Condition that matches the ConditionType
 	// previously set on Conditions.
 	GetCondition(t ConditionType) *Condition
@@ -139,13 +142,15 @@ func (r ConditionSet) Manage(status ConditionsAccessor) ConditionManager {
 	}
 }
 
-// IsHappy looks at the happy condition and returns true if that condition is
+// IsHappy looks at the top level Condition (happy Condition) and returns true if that condition is
 // set to true.
 func (r conditionsImpl) IsHappy() bool {
-	if c := r.GetCondition(r.happy); c == nil || !c.IsTrue() {
+	return r.GetTopLevelCondition().IsTrue()
-		return false
 }
-	return true
+
+// GetTopLevelCondition finds and returns the top level Condition (happy Condition).
+func (r conditionsImpl) GetTopLevelCondition() *Condition {
+	return r.GetCondition(r.happy)
 }
 
 // GetCondition finds and returns the Condition that matches the ConditionType

vendor/knative.dev/pkg/injection/sharedmain/main.go

@@ -106,7 +106,7 @@ func MainWithContext(ctx context.Context, component string, ctors ...injection.C
 
 	cfg, err := GetConfig(*masterURL, *kubeconfig)
 	if err != nil {
-		log.Fatal("Error building kubeconfig", err)
+		log.Fatalf("Error building kubeconfig: %v", err)
 	}
 	MainWithConfig(ctx, component, cfg, ctors...)
 }
@@ -134,7 +134,7 @@ func MainWithConfig(ctx context.Context, component string, cfg *rest.Config, cto
 	// Set up our logger.
 	loggingConfig, err := GetLoggingConfig(ctx)
 	if err != nil {
-		log.Fatal("Error reading/parsing logging configuration:", err)
+		log.Fatalf("Error reading/parsing logging configuration: %v", err)
 	}
 	logger, atomicLevel := logging.NewLoggerFromConfig(loggingConfig, component)
 	defer flush(logger)
@@ -168,7 +168,7 @@ func MainWithConfig(ctx context.Context, component string, cfg *rest.Config, cto
 		metav1.GetOptions{}); err == nil {
 		cmw.Watch(logging.ConfigMapName(), logging.UpdateLevelFromConfigMap(logger, atomicLevel, component))
 	} else if !apierrors.IsNotFound(err) {
-		logger.Fatalw("Error reading ConfigMap: "+logging.ConfigMapName(), zap.Error(err))
+		logger.With(zap.Error(err)).Fatalf("Error reading ConfigMap %q", logging.ConfigMapName())
 	}
 
 	// Watch the observability config map
@@ -178,17 +178,17 @@ func MainWithConfig(ctx context.Context, component string, cfg *rest.Config, cto
 			metrics.UpdateExporterFromConfigMap(component, logger),
 			profilingHandler.UpdateFromConfigMap)
 	} else if !apierrors.IsNotFound(err) {
-		logger.Fatalw("Error reading ConfigMap: "+metrics.ConfigMapName(), zap.Error(err))
+		logger.With(zap.Error(err)).Fatalf("Error reading ConfigMap %q", metrics.ConfigMapName())
 	}
 
 	if err := cmw.Start(ctx.Done()); err != nil {
-		logger.Fatalw("failed to start configuration manager", zap.Error(err))
+		logger.Fatalw("Failed to start configuration manager", zap.Error(err))
 	}
 
 	// Start all of the informers and wait for them to sync.
 	logger.Info("Starting informers.")
 	if err := controller.StartInformers(ctx.Done(), informers...); err != nil {
-		logger.Fatalw("Failed to start informers", err)
+		logger.Fatalw("Failed to start informers", zap.Error(err))
 	}
 
 	// Start all of the controllers.

vendor/knative.dev/pkg/metrics/config.go

@@ -212,7 +212,7 @@ func createMetricsConfig(ops ExporterOptions, logger *zap.SugaredLogger) (*metri
 
 		if !allowCustomMetrics {
 			servingOrEventing := metricskey.KnativeRevisionMetrics.Union(
-				metricskey.KnativeTriggerMetrics)
+				metricskey.KnativeTriggerMetrics).Union(metricskey.KnativeBrokerMetrics)
 			mc.recorder = func(ctx context.Context, ms stats.Measurement, ros ...stats.Options) error {
 				metricType := path.Join(mc.stackdriverMetricTypePrefix, ms.Measure().Name())
 

vendor/knative.dev/pkg/metrics/metricskey/constants_serving.go

@@ -67,5 +67,6 @@ var (
 		"knative.dev/internal/serving/controller/cert_expiration_durations",
 		"knative.dev/internal/serving/controller/cert_total_num",
 		"knative.dev/internal/serving/controller/cert_issuance_latencies",
+		"knative.dev/internal/serving/controller/cert_creation_count",
 	)
 )

vendor/knative.dev/pkg/testutils/clustermanager/prow-cluster-operation/actions/create.go

@@ -85,14 +85,14 @@ func writeMetaData(cluster *container.Cluster, project string) {
 }
 
 // Create creates a GKE cluster and configures gcloud after successful GKE create request
-func Create(o *options.RequestWrapper) error {
+func Create(o *options.RequestWrapper) (*clm.GKECluster, error) {
 	o.Prep()
 
 	gkeClient := clm.GKEClient{}
 	clusterOps := gkeClient.Setup(o.Request)
 	gkeOps := clusterOps.(*clm.GKECluster)
 	if err := gkeOps.Acquire(); err != nil || gkeOps.Cluster == nil {
-		return fmt.Errorf("failed acquiring GKE cluster: '%v'", err)
+		return nil, fmt.Errorf("failed acquiring GKE cluster: '%v'", err)
 	}
 
 	// At this point we should have a cluster ready to run test. Need to save
@@ -104,11 +104,11 @@ func Create(o *options.RequestWrapper) error {
 	// TODO(chaodaiG): this probably should also be part of clustermanager lib
 	if out, err := common.StandardExec("gcloud", "beta", "container", "clusters", "get-credentials",
 		gkeOps.Cluster.Name, "--region", gkeOps.Cluster.Location, "--project", gkeOps.Project); err != nil {
-		return fmt.Errorf("failed connecting to cluster: %q, '%v'", out, err)
+		return nil, fmt.Errorf("failed connecting to cluster: %q, '%v'", out, err)
 	}
 	if out, err := common.StandardExec("gcloud", "config", "set", "project", gkeOps.Project); err != nil {
-		return fmt.Errorf("failed setting gcloud: %q, '%v'", out, err)
+		return nil, fmt.Errorf("failed setting gcloud: %q, '%v'", out, err)
 	}
 
-	return nil
+	return gkeOps, nil
 }

vendor/knative.dev/pkg/testutils/clustermanager/prow-cluster-operation/actions/get.go

@@ -17,11 +17,12 @@ limitations under the License.
 package actions
 
 import (
+	clm "knative.dev/pkg/testutils/clustermanager/e2e-tests"
 	"knative.dev/pkg/testutils/clustermanager/prow-cluster-operation/options"
 )
 
 // Get gets a GKE cluster
-func Get(o *options.RequestWrapper) error {
+func Get(o *options.RequestWrapper) (*clm.GKECluster, error) {
 	o.Prep()
 	o.Request.SkipCreation = true
 	// Reuse `Create` for getting operation, so that we can reuse the same logic

vendor/knative.dev/pkg/testutils/clustermanager/prow-cluster-operation/main.go

@@ -45,11 +45,11 @@ func main() {
 	}
 	switch {
 	case create:
-		err = actions.Create(o)
+		_, err = actions.Create(o)
 	case delete:
 		err = actions.Delete(o)
 	case get:
-		err = actions.Get(o)
+		_, err = actions.Get(o)
 	default:
 		err = errors.New("Must pass one of --create, --delete, --get")
 	}

vendor/knative.dev/pkg/version/version.go

@@ -37,7 +37,7 @@ const (
 	// the Kubernetes minimum version required by Knative.
 	KubernetesMinVersionKey = "KUBERNETES_MIN_VERSION"
 
-	defaultMinimumVersion = "v1.14.0"
+	defaultMinimumVersion = "v1.15.0"
 )
 
 func getMinimumVersion() string {