knative
/
client
mirror of https://github.com/knative/client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added back functionality to deprecated max-scale/min-scale (#1010) 

* Added back functionality to deprecated max-scale/min-scale

* Updated based on review, removed duplicate code and added an or statement, also updated deprecated message
This commit is contained in:
Mike Petersen 2020-10-06 11:07:21 -07:00 committed by GitHub
parent 6baab2eda4
commit 0997cb05b6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/kn/commands/service/configuration_edit_flags.go
View File

@ -336,14 +336,16 @@ func (p *ConfigurationEditFlags) Apply(
}
}
if cmd.Flags().Changed("scale-min") {
// Deprecated "min-scale" in 0.19, updated to "scale-min"
if cmd.Flags().Changed("scale-min") || cmd.Flags().Changed("min-scale") {
err = servinglib.UpdateMinScale(template, p.MinScale)
if err != nil {
return err
}
}
if cmd.Flags().Changed("scale-max") {
// Deprecated "max-scale" in 0.19, updated to "scale-max"
if cmd.Flags().Changed("scale-max") || cmd.Flags().Changed("max-scale") {
err = servinglib.UpdateMaxScale(template, p.MaxScale)
if err != nil {
return err