From 0997cb05b6b8724a4cad448ebc9b0cf9223f170c Mon Sep 17 00:00:00 2001 From: Mike Petersen Date: Tue, 6 Oct 2020 11:07:21 -0700 Subject: [PATCH] Added back functionality to deprecated max-scale/min-scale (#1010) * Added back functionality to deprecated max-scale/min-scale * Updated based on review, removed duplicate code and added an or statement, also updated deprecated message --- pkg/kn/commands/service/configuration_edit_flags.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/kn/commands/service/configuration_edit_flags.go b/pkg/kn/commands/service/configuration_edit_flags.go index ebf31c5f0..d14f72fb6 100644 --- a/pkg/kn/commands/service/configuration_edit_flags.go +++ b/pkg/kn/commands/service/configuration_edit_flags.go @@ -336,14 +336,16 @@ func (p *ConfigurationEditFlags) Apply( } } - if cmd.Flags().Changed("scale-min") { + // Deprecated "min-scale" in 0.19, updated to "scale-min" + if cmd.Flags().Changed("scale-min") || cmd.Flags().Changed("min-scale") { err = servinglib.UpdateMinScale(template, p.MinScale) if err != nil { return err } } - if cmd.Flags().Changed("scale-max") { + // Deprecated "max-scale" in 0.19, updated to "scale-max" + if cmd.Flags().Changed("scale-max") || cmd.Flags().Changed("max-scale") { err = servinglib.UpdateMaxScale(template, p.MaxScale) if err != nil { return err