mirror of https://github.com/knative/client.git
fix(build.sh): Change from xnotify to fswatch for watching source code (#171)
While working with `build.sh --watch` it turned out the underlying tool xnotify is not matured enough: * It doesn't work when IntelliJ IDEA changes a file * It can't deal with ignoring newly generated temp files (like .swp for vi) This commit exchanges xnotify with fswatch which is much more matured.
This commit is contained in:
parent
ecc61d59c1
commit
0d94947366
|
|
@ -112,27 +112,27 @@ generate_docs() {
|
|||
|
||||
watch() {
|
||||
local command="./hack/build.sh --fast"
|
||||
local notify_opts="--include cmd --include pkg --batch 500"
|
||||
local fswatch_opts='-e "^\..*$" -o pkg cmd'
|
||||
if $(has_flag --test -t); then
|
||||
command="$command --test"
|
||||
fi
|
||||
if $(has_flag --verbose); then
|
||||
notify_opts="$notify_opts --verbose"
|
||||
fswatch_opts="$fswatch_opts -v"
|
||||
fi
|
||||
set +e
|
||||
which xnotify >/dev/null 2>&1
|
||||
which fswatch >/dev/null 2>&1
|
||||
if [ $? -ne 0 ]; then
|
||||
local green="[32m"
|
||||
local reset="[39m"
|
||||
|
||||
echo "🤷 Watch: Cannot find ${green}xnotify${reset}"
|
||||
echo "🌏 Please download from ${green}https://github.com/AgentCosmic/xnotify/releases${reset} and install in \$PATH"
|
||||
echo "🤷 Watch: Cannot find ${green}fswatch${reset}"
|
||||
echo "🌏 Please see ${green}http://emcrisostomo.github.io/fswatch/${reset} for installation instructions"
|
||||
exit 1
|
||||
fi
|
||||
set -e
|
||||
|
||||
echo "🔁 Watch"
|
||||
xnotify $notify_opts -- $command
|
||||
fswatch $fswatch_opts | xargs -n1 -I{} $command
|
||||
}
|
||||
|
||||
# Dir where this script is located
|
||||
|
|
|
|||
Loading…
Reference in New Issue