Do not cleanup on failure in Tekton tests (#1369)

* Cleanup Tekton tests only on success

* TMP: Run in presubmits

* Skip Istio addon in Tekton tests

* Revert "TMP: Run in presubmits"

This reverts commit d050971465.

test/e2e/tekton_test.go

@@ -40,9 +40,6 @@ const (
 func TestTektonPipeline(t *testing.T) {
 	it, err := test.NewKnTest()
 	assert.NilError(t, err)
-	defer func() {
-		assert.NilError(t, it.Teardown())
-	}()
 
 	kubectl := test.NewKubectl(it.Namespace())
 	basedir := test.CurrentDir(t) + "/../resources/tekton"
@@ -89,6 +86,7 @@ func TestTektonPipeline(t *testing.T) {
 	r.AssertNoError(out)
 	assert.Assert(t, util.ContainsAll(out.Stdout, serviceName, it.Kn().Namespace()))
 	assert.Assert(t, util.ContainsAll(out.Stdout, "Conditions", "ConfigurationsReady", "Ready", "RoutesReady"))
+	assert.NilError(t, it.Teardown())
 }
 
 func waitForPipelineSuccess(k test.Kubectl) error {

test/tekton-tests.sh

@@ -26,7 +26,7 @@ source $(dirname $0)/common.sh
 export PATH=$PATH:${REPO_ROOT_DIR}
 
 # Script entry point.
-initialize $@
+initialize $@ --skip-istio-addon
 
 export TEKTON_VERSION=${TEKTON_VERSION:-v0.11.1}
 export KN_E2E_NAMESPACE=tkn-kn