knative
/
client
mirror of https://github.com/knative/client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rename configUID label to ConfigurationUID (#1199) 

followed up by https://github.com/knative/serving/pull/10579
This commit is contained in:
Navid Shaikh 2021-01-21 13:08:53 +05:30 committed by GitHub
parent dc52d5bc8a
commit 16ec3c1023
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/kn/commands/service/export.go
View File

@ -53,14 +53,14 @@ var IgnoredRevisionAnnotations = []string{
// IgnoredServiceLabels defines the label keys which should be removed
// from service labels before export
var IgnoredServiceLabels = []string{
"serving.knative.dev/configUID",
"serving.knative.dev/configurationUID",
"serving.knative.dev/serviceUID",
}
// IgnoredRevisionLabels defines the label keys which should be removed
// from revision labels before export
var IgnoredRevisionLabels = []string{
"serving.knative.dev/configUID",
"serving.knative.dev/configurationUID",
"serving.knative.dev/serviceUID",
}

6
test/e2e/service_export_test.go
View File

@ -227,7 +227,7 @@ func TestServiceExport(t *testing.T) {
))),
), "--with-revisions", "--mode", "export", "-o", "yaml")
t.Log("create and export service 'foo' and verify that serviceUID and configUID labels are absent")
t.Log("create and export service 'foo' and verify that serviceUID and configurationUID labels are absent")
serviceCreateWithOptions(r, "foo")
output := serviceExportOutput(r, "foo", "-o", "json")
actSvc := servingv1.Service{}
@ -235,11 +235,11 @@ func TestServiceExport(t *testing.T) {
assert.NilError(t, err)
_, ok := actSvc.Labels["serving.knative.dev/serviceUID"]
assert.Equal(t, ok, false)
_, ok = actSvc.Labels["serving.knative.dev/configUID"]
_, ok = actSvc.Labels["serving.knative.dev/configurationUID"]
assert.Equal(t, ok, false)
_, ok = actSvc.Spec.ConfigurationSpec.Template.Labels["serving.knative.dev/servingUID"]
assert.Equal(t, ok, false)
_, ok = actSvc.Spec.ConfigurationSpec.Template.Labels["serving.knative.dev/configUID"]
_, ok = actSvc.Spec.ConfigurationSpec.Template.Labels["serving.knative.dev/configurationUID"]
assert.Equal(t, ok, false)
}