From 339232b795b124c06ee9a6ede64f72965090eb09 Mon Sep 17 00:00:00 2001 From: Navid Shaikh Date: Fri, 29 Nov 2019 18:06:22 +0530 Subject: [PATCH] fix(e2e): Removes explicit timeout flag in smoke tests (#523) Fixes #507 - removes `--wait-timeout` flag, was set to 240 seconds which is lesser than the default timeout (600 seconds) - removes duplication of namespace flag in another smoke test command --- test/e2e-smoke-tests.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e-smoke-tests.sh b/test/e2e-smoke-tests.sh index ce88e216e..718c78297 100755 --- a/test/e2e-smoke-tests.sh +++ b/test/e2e-smoke-tests.sh @@ -49,8 +49,8 @@ kubectl create ns $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test sleep 4 # Wait for the namespace to get initialized by kube-controller-manager ./kn service create svc1 --async --image gcr.io/knative-samples/helloworld-go -e TARGET=Knative -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test -./kn service create hello --image gcr.io/knative-samples/helloworld-go -e TARGET=Knative -n $KN_E2E_SMOKE_TESTS_NAMESPACE --wait-timeout 240 || fail_test -./kn service list hello -n $KN_E2E_SMOKE_TESTS_NAMESPACE -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test +./kn service create hello --image gcr.io/knative-samples/helloworld-go -e TARGET=Knative -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test +./kn service list hello -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test ./kn service update hello --env TARGET=kn -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test ./kn revision list hello -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test ./kn service list -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test