knative
/
client
mirror of https://github.com/knative/client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove unnecessary help message (#1158)

This commit is contained in:
kaustubh 2020-12-01 17:50:36 +05:30 committed by GitHub
parent dfbd81e2f3
commit 3990a45591
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGELOG.adoc
View File

@ -17,6 +17,10 @@
|=== |===
| | Description | PR | | Description | PR
| 🐣
| Removes unnecessary help message introduced for machine-readable outputs for command 'kn source binding describe'
| https://github.com/knative/client/pull/1158[#1158]
| 🐣 | 🐣
| Removes unnecessary help message introduced for machine-readable outputs for commands which does not have -o url flag | Removes unnecessary help message introduced for machine-readable outputs for commands which does not have -o url flag
| https://github.com/knative/client/pull/1152[#1152] | https://github.com/knative/client/pull/1152[#1152]
@ -33,7 +37,7 @@
| Add machine readable output (-o flag) to kn source binding describe | Add machine readable output (-o flag) to kn source binding describe
| https://github.com/knative/client/pull/1148[#1148] | https://github.com/knative/client/pull/1148[#1148]
| 🐛 | 🎁
| Add machine readable output (-o flag) to kn source apiserver describe | Add machine readable output (-o flag) to kn source apiserver describe
| https://github.com/knative/client/pull/1146[#1146] | https://github.com/knative/client/pull/1146[#1146]

2
pkg/kn/commands/source/binding/describe.go
View File

@ -18,7 +18,6 @@ import (
"errors" "errors"
"fmt" "fmt"
"sort" "sort"
"strings"
"github.com/spf13/cobra" "github.com/spf13/cobra"
"k8s.io/cli-runtime/pkg/genericclioptions" "k8s.io/cli-runtime/pkg/genericclioptions"
@ -99,7 +98,6 @@ func NewBindingDescribeCommand(p *commands.KnParams) *cobra.Command {
commands.AddNamespaceFlags(flags, false) commands.AddNamespaceFlags(flags, false)
flags.BoolP("verbose", "v", false, "More output.") flags.BoolP("verbose", "v", false, "More output.")
machineReadablePrintFlags.AddFlags(command) machineReadablePrintFlags.AddFlags(command)
command.Flag("output").Usage = fmt.Sprintf("Output format. One of: %s.", strings.Join(machineReadablePrintFlags.AllowedFormats(), "|"))
return command return command
} }