knative
/
client
mirror of https://github.com/knative/client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve error message (#486) 

While testing I specified this on the `kn` command line:

```
./kn service create echo --concurrency-limit=1 --concurrency-target=1 --env foo=bar --limits-cpu=1000m --limits-memory=1024m --max-scale=1 --min-scale=1 --port=9999 --requests-cpu=250m --requests-memory=64mi --image duglin/echo
```
and it returned:
```
unable to parse quantity's suffix
```

I had no idea which value it didn't like. So this PR makes it so the output
is now this:
```
Error parsing "64mi": unable to parse quantity's suffix
```

Still not perfect since I still had to think way too hard to realize that it
didn't like the lower-case `m`, but that's a different issue.

Signed-off-by: Doug Davis <dug@us.ibm.com>
This commit is contained in:
Doug Davis 2019-11-06 16:21:03 -05:00 committed by Knative Prow Robot
parent 22c65d65ef
commit 39b7313fb0
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/kn/commands/service/configuration_edit_flags.go
View File

@ -361,7 +361,8 @@ func (p *ConfigurationEditFlags) computeResources(resourceFlags ResourceFlags) (
if resourceFlags.CPU != "" { if resourceFlags.CPU != "" {
cpuQuantity, err := resource.ParseQuantity(resourceFlags.CPU) cpuQuantity, err := resource.ParseQuantity(resourceFlags.CPU)
if err != nil { if err != nil {
return corev1.ResourceList{}, err return corev1.ResourceList{},
errors.Wrapf(err, "Error parsing %q", resourceFlags.CPU)
} }
resourceList[corev1.ResourceCPU] = cpuQuantity resourceList[corev1.ResourceCPU] = cpuQuantity
@ -370,7 +371,8 @@ func (p *ConfigurationEditFlags) computeResources(resourceFlags ResourceFlags) (
if resourceFlags.Memory != "" { if resourceFlags.Memory != "" {
memoryQuantity, err := resource.ParseQuantity(resourceFlags.Memory) memoryQuantity, err := resource.ParseQuantity(resourceFlags.Memory)
if err != nil { if err != nil {
return corev1.ResourceList{}, err return corev1.ResourceList{},
errors.Wrapf(err, "Error parsing %q", resourceFlags.Memory)
} }
resourceList[corev1.ResourceMemory] = memoryQuantity resourceList[corev1.ResourceMemory] = memoryQuantity