From 43b37a6747f7ad9074a93f2326f5ec7b3c4f7f27 Mon Sep 17 00:00:00 2001 From: "dr.max" Date: Sat, 29 Jun 2019 03:04:08 +0800 Subject: [PATCH] Fixes `limits-memory` and `requests-memory` descriptions (#198) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Erroneously showed ‘CPU’ for ‘memory’ in description strings --- docs/cmd/kn_service_create.md | 4 ++-- docs/cmd/kn_service_update.md | 4 ++-- pkg/kn/commands/service/configuration_edit_flags.go | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/cmd/kn_service_create.md b/docs/cmd/kn_service_create.md index 589f39e3b..ac7d47969 100644 --- a/docs/cmd/kn_service_create.md +++ b/docs/cmd/kn_service_create.md @@ -47,13 +47,13 @@ kn service create NAME --image IMAGE [flags] -h, --help help for create --image string Image to run. --limits-cpu string The limits on the requested CPU (e.g., 1000m). - --limits-memory string The limits on the requested CPU (e.g., 1024Mi). + --limits-memory string The limits on the requested memory (e.g., 1024Mi). --max-scale int Maximal number of replicas. --min-scale int Minimal number of replicas. -n, --namespace string List the requested object(s) in given namespace. -p, --port int32 The port where application listens on. --requests-cpu string The requested CPU (e.g., 250m). - --requests-memory string The requested CPU (e.g., 64Mi). + --requests-memory string The requested memory (e.g., 64Mi). --wait-timeout int Seconds to wait before giving up on waiting for service to be ready (default: 60). (default 60) ``` diff --git a/docs/cmd/kn_service_update.md b/docs/cmd/kn_service_update.md index 454bde70f..c9fda2e65 100644 --- a/docs/cmd/kn_service_update.md +++ b/docs/cmd/kn_service_update.md @@ -33,13 +33,13 @@ kn service update NAME [flags] -h, --help help for update --image string Image to run. --limits-cpu string The limits on the requested CPU (e.g., 1000m). - --limits-memory string The limits on the requested CPU (e.g., 1024Mi). + --limits-memory string The limits on the requested memory (e.g., 1024Mi). --max-scale int Maximal number of replicas. --min-scale int Minimal number of replicas. -n, --namespace string List the requested object(s) in given namespace. -p, --port int32 The port where application listens on. --requests-cpu string The requested CPU (e.g., 250m). - --requests-memory string The requested CPU (e.g., 64Mi). + --requests-memory string The requested memory (e.g., 64Mi). ``` ### Options inherited from parent commands diff --git a/pkg/kn/commands/service/configuration_edit_flags.go b/pkg/kn/commands/service/configuration_edit_flags.go index 44db71ad2..a80072e40 100644 --- a/pkg/kn/commands/service/configuration_edit_flags.go +++ b/pkg/kn/commands/service/configuration_edit_flags.go @@ -48,9 +48,9 @@ func (p *ConfigurationEditFlags) AddUpdateFlags(command *cobra.Command) { "Environment variable to set. NAME=value; you may provide this flag "+ "any number of times to set multiple environment variables.") command.Flags().StringVar(&p.RequestsFlags.CPU, "requests-cpu", "", "The requested CPU (e.g., 250m).") - command.Flags().StringVar(&p.RequestsFlags.Memory, "requests-memory", "", "The requested CPU (e.g., 64Mi).") + command.Flags().StringVar(&p.RequestsFlags.Memory, "requests-memory", "", "The requested memory (e.g., 64Mi).") command.Flags().StringVar(&p.LimitsFlags.CPU, "limits-cpu", "", "The limits on the requested CPU (e.g., 1000m).") - command.Flags().StringVar(&p.LimitsFlags.Memory, "limits-memory", "", "The limits on the requested CPU (e.g., 1024Mi).") + command.Flags().StringVar(&p.LimitsFlags.Memory, "limits-memory", "", "The limits on the requested memory (e.g., 1024Mi).") command.Flags().IntVar(&p.MinScale, "min-scale", 0, "Minimal number of replicas.") command.Flags().IntVar(&p.MaxScale, "max-scale", 0, "Maximal number of replicas.") command.Flags().IntVar(&p.ConcurrencyTarget, "concurrency-target", 0, "Recommendation for when to scale up based on the concurrent number of incoming request. Defaults to --concurrency-limit when given.")