knative
/
client
mirror of https://github.com/knative/client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix analyzer warnings (#412) 

* remove unused codes (structcheck)(varcheck)

* add error handling (errcheck)

* add error handling (ineffassign)

* fix lint errors (golint)
This commit is contained in:
Toshinori Sugita 2019-09-23 19:03:12 +09:00 committed by Knative Prow Robot
parent 94bb1cf8db
commit 43f8386b82
6 changed files with 32 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
pkg/kn/commands/service/update_test.go
View File

@ -143,7 +143,10 @@ func TestServiceUpdateImageSync(t *testing.T) {
t.Fatal(err)
}
servinglib.UpdateImage(template, "gcr.io/foo/bar:baz")
err = servinglib.UpdateImage(template, "gcr.io/foo/bar:baz")
if err != nil {
t.Fatal(err)
}
action, updated, output, err := fakeServiceUpdate(orig, []string{
"service", "update", "foo", "--image", "gcr.io/foo/quux:xyzzy", "--namespace", "bar"}, true)
@ -166,7 +169,10 @@ func TestServiceUpdateImage(t *testing.T) {
t.Fatal(err)
}
servinglib.UpdateImage(template, "gcr.io/foo/bar:baz")
err = servinglib.UpdateImage(template, "gcr.io/foo/bar:baz")
if err != nil {
t.Fatal(err)
}
action, updated, output, err := fakeServiceUpdate(orig, []string{
"service", "update", "foo", "--image", "gcr.io/foo/quux:xyzzy", "--namespace", "bar", "--async"}, false)
@ -371,7 +377,10 @@ func TestServiceUpdatePinsToDigestWhenAsked(t *testing.T) {
t.Fatal(err)
}
servinglib.UpdateImage(template, "gcr.io/foo/bar:baz")
err = servinglib.UpdateImage(template, "gcr.io/foo/bar:baz")
if err != nil {
t.Fatal(err)
}
action, updated, _, err := fakeServiceUpdate(orig, []string{
"service", "update", "foo", "-e", "TARGET=Awesome", "--lock-to-digest", "--async"}, false)
@ -396,7 +405,10 @@ func TestServiceUpdatePinsToDigestWhenPreviouslyDidSo(t *testing.T) {
t.Fatal(err)
}
servinglib.UpdateImage(template, "gcr.io/foo/bar:baz")
err = servinglib.UpdateImage(template, "gcr.io/foo/bar:baz")
if err != nil {
t.Fatal(err)
}
action, updated, _, err := fakeServiceUpdate(orig, []string{
"service", "update", "foo", "-e", "TARGET=Awesome", "--async"}, false)
@ -421,7 +433,10 @@ func TestServiceUpdateDoesntPinToDigestWhenUnAsked(t *testing.T) {
t.Fatal(err)
}
servinglib.UpdateImage(template, "gcr.io/foo/bar:baz")
err = servinglib.UpdateImage(template, "gcr.io/foo/bar:baz")
if err != nil {
t.Fatal(err)
}
action, updated, _, err := fakeServiceUpdate(orig, []string{
"service", "update", "foo", "-e", "TARGET=Awesome", "--no-lock-to-digest", "--async"}, false)
@ -443,12 +458,15 @@ func TestServiceUpdateDoesntPinToDigestWhenPreviouslyDidnt(t *testing.T) {
orig := newEmptyService()
template, err := servinglib.RevisionTemplateOfService(orig)
delete(template.Annotations, servinglib.UserImageAnnotationKey)
if err != nil {
t.Fatal(err)
}
delete(template.Annotations, servinglib.UserImageAnnotationKey)
servinglib.UpdateImage(template, "gcr.io/foo/bar:baz")
err = servinglib.UpdateImage(template, "gcr.io/foo/bar:baz")
if err != nil {
t.Fatal(err)
}
action, updated, _, err := fakeServiceUpdate(orig, []string{
"service", "update", "foo", "-e", "TARGET=Awesome", "--async"}, false)

2
pkg/kn/commands/testing_helper.go
View File

@ -39,8 +39,6 @@ var (
output string
readFile, writeFile *os.File
origArgs []string
)
// CreateTestKnCommand helper for creating test commands

2
pkg/kn/commands/types_test.go
View File

@ -106,8 +106,6 @@ type typeTestCase struct {
func TestGetClientConfig(t *testing.T) {
multiConfigs := fmt.Sprintf("%s%s%s", "/testing/assets/kube-config-01.yml", string(os.PathListSeparator), "/testing/assets/kube-config-02.yml")
multiConfigs = multiConfigs
for _, tc := range []typeTestCase{
{
"",

1
pkg/printers/tablegenerator.go
View File

@ -38,7 +38,6 @@ type PrintHandler interface {
type handlerEntry struct {
columnDefinitions []metav1beta1.TableColumnDefinition
printFunc reflect.Value
args []reflect.Value
}
// HumanReadablePrinter is an implementation of ResourcePrinter which attempts to provide

8
pkg/serving/config_changes.go
View File

@ -165,11 +165,15 @@ func SetUserImageAnnot(template *servingv1alpha1.RevisionTemplateSpec) {
// FreezeImageToDigest sets the image on the template to the image digest of the base revision.
func FreezeImageToDigest(template *servingv1alpha1.RevisionTemplateSpec, baseRevision *servingv1alpha1.Revision) error {
currentContainer, err := ContainerOfRevisionTemplate(template)
if baseRevision == nil {
return nil
}
currentContainer, err := ContainerOfRevisionTemplate(template)
if err != nil {
return err
}
baseContainer, err := ContainerOfRevisionSpec(&baseRevision.Spec)
if err != nil {
return err

3
pkg/serving/v1alpha1/client_test.go
View File

@ -422,9 +422,8 @@ func TestGetBaseRevision(t *testing.T) {
if c.foundRevisionImage != "" {
revision.Spec.Containers[0].Image = c.foundRevisionImage
return true, revision, nil
} else {
return true, nil, errors.NewNotFound(v1alpha1.Resource("revision"), name)
}
return true, nil, errors.NewNotFound(v1alpha1.Resource("revision"), name)
})
for _, c = range cases {
service := v1alpha1.Service{}