knative
/
client
mirror of https://github.com/knative/client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

removes zsh completion since it does not work (fixes #426) (#439)

This commit is contained in:
dr.max 2019-10-23 00:43:27 -07:00 committed by Knative Prow Robot
parent f77c034c4a
commit 462973c51f
2 changed files with 5 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
pkg/kn/commands/completion.go
View File

@ -20,26 +20,13 @@ import (
"github.com/spf13/cobra"
)
type CompletionFlags struct {
Zsh bool
}
func NewCompletionCommand(p *KnParams) *cobra.Command {
var completionFlags CompletionFlags
completionCmd := &cobra.Command{
return &cobra.Command{
Use: "completion",
Short: "Output shell completion code (default Bash)",
Hidden: true, // Don't show this in help listing.
Short: "Output shell completion code (Bash)",
Hidden: true, // Don't show this in help listing
Run: func(cmd *cobra.Command, args []string) {
if completionFlags.Zsh {
cmd.Root().GenZshCompletion(os.Stdout)
} else {
cmd.Root().GenBashCompletion(os.Stdout)
}
cmd.Root().GenBashCompletion(os.Stdout)
},
}
completionCmd.Flags().BoolVar(&completionFlags.Zsh, "zsh", false, "Generates completion code for Zsh shell.")
return completionCmd
}

11
pkg/kn/commands/completion_test.go
View File

@ -38,7 +38,7 @@ func TestCompletion(t *testing.T) {
t.Run("creates a CompletionCommand", func(t *testing.T) {
setup()
assert.Equal(t, completionCmd.Use, "completion")
assert.Equal(t, completionCmd.Short, "Output shell completion code (default Bash)")
assert.Equal(t, completionCmd.Short, "Output shell completion code (Bash)")
assert.Assert(t, completionCmd.RunE == nil)
})
@ -50,13 +50,4 @@ func TestCompletion(t *testing.T) {
completionCmd.Run(fakeRootCmd, []string{})
assert.Assert(t, ReadStdout(t) != "")
})
t.Run("returns completion code for ZSH", func(t *testing.T) {
setup()
CaptureStdout(t)
defer ReleaseStdout(t)
completionCmd.Run(fakeRootCmd, []string{"--zsh"})
assert.Assert(t, ReadStdout(t) != "")
})
}