From 48797269edea2ba06a4dd14e1b0ca3dc2eedbd8a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Roland=20Hu=C3=9F?= <roland@ro14nd.de>
Date: Tue, 19 Nov 2019 11:20:07 +0100
Subject: [PATCH] chore: Add version information of eventing (#495)

* chore: Add version information of eventing

Adding sources.eventing.knative.dev to version info (the only eventing API)
for now as this will be the first one used.

* chore(version): Add grouping for API versions
---
 pkg/kn/commands/version/version.go      | 18 ++++++++++++++----
 pkg/kn/commands/version/version_test.go |  5 ++++-
 2 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/pkg/kn/commands/version/version.go b/pkg/kn/commands/version/version.go
index e34c98333..e6139c821 100644
--- a/pkg/kn/commands/version/version.go
+++ b/pkg/kn/commands/version/version.go
@@ -27,8 +27,13 @@ var BuildDate string
 var GitRevision string
 
 // update this var as we add more deps
-var apiVersions = []string{
-	"serving.knative.dev/v1alpha1 (knative-serving v0.10.0)",
+var apiVersions = map[string][]string{
+	"serving": {
+		"serving.knative.dev/v1alpha1 (knative-serving v0.10.0)",
+	},
+	"eventing": {
+		"sources.eventing.knative.dev/v1alpha1 (knative-eventing v0.10.0)",
+	},
 }
 
 // NewVersionCommand implements 'kn version' command
@@ -42,8 +47,13 @@ func NewVersionCommand(p *commands.KnParams) *cobra.Command {
 			fmt.Fprintf(out, "Build Date:   %s\n", BuildDate)
 			fmt.Fprintf(out, "Git Revision: %s\n", GitRevision)
 			fmt.Fprintf(out, "Supported APIs:\n")
-			for _, api := range apiVersions {
-				fmt.Fprintf(out, "- %s\n", api)
+			fmt.Fprintf(out, "* Serving\n")
+			for _, api := range apiVersions["serving"] {
+				fmt.Fprintf(out, "  - %s\n", api)
+			}
+			fmt.Fprintf(out, "* Eventing\n")
+			for _, api := range apiVersions["eventing"] {
+				fmt.Fprintf(out, "  - %s\n", api)
 			}
 		},
 	}
diff --git a/pkg/kn/commands/version/version_test.go b/pkg/kn/commands/version/version_test.go
index 754a38008..8ea4e12b9 100644
--- a/pkg/kn/commands/version/version_test.go
+++ b/pkg/kn/commands/version/version_test.go
@@ -35,7 +35,10 @@ var versionOutputTemplate = `Version:      {{.Version}}
 Build Date:   {{.BuildDate}}
 Git Revision: {{.GitRevision}}
 Supported APIs:
-- serving.knative.dev/v1alpha1 (knative-serving v0.10.0)
+* Serving
+  - serving.knative.dev/v1alpha1 (knative-serving v0.10.0)
+* Eventing
+  - sources.eventing.knative.dev/v1alpha1 (knative-eventing v0.10.0)
 `
 
 const (