From 48f4359b24c0b97d41621cd453cfa8352a0a643a Mon Sep 17 00:00:00 2001 From: Navid Shaikh Date: Wed, 15 Apr 2020 06:50:47 +0530 Subject: [PATCH] e2e: Foreground delete for revisions and services in e2e (#794) * e2e: Foreground delete for revisions and services in e2e to avoid any race conditions and flakes * Use --wait instead of --no-wait=false --- test/e2e/basic_workflow_test.go | 2 +- test/e2e/revision_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e/basic_workflow_test.go b/test/e2e/basic_workflow_test.go index 4d4ebdd3d..fa3781411 100644 --- a/test/e2e/basic_workflow_test.go +++ b/test/e2e/basic_workflow_test.go @@ -131,7 +131,7 @@ func serviceUpdate(r *test.KnRunResultCollector, serviceName string, args ...str } func serviceDelete(r *test.KnRunResultCollector, serviceName string) { - out := r.KnTest().Kn().Run("service", "delete", serviceName) + out := r.KnTest().Kn().Run("service", "delete", "--wait", serviceName) r.AssertNoError(out) assert.Check(r.T(), util.ContainsAll(out.Stdout, "Service", serviceName, "successfully deleted in namespace", r.KnTest().Kn().Namespace())) } diff --git a/test/e2e/revision_test.go b/test/e2e/revision_test.go index 504cc68fd..bc8907cd3 100644 --- a/test/e2e/revision_test.go +++ b/test/e2e/revision_test.go @@ -98,7 +98,7 @@ func revisionListWithService(r *test.KnRunResultCollector, serviceNames ...strin } func revisionDelete(r *test.KnRunResultCollector, revName string) { - out := r.KnTest().Kn().Run("revision", "delete", revName) + out := r.KnTest().Kn().Run("revision", "delete", "--wait", revName) assert.Check(r.T(), util.ContainsAll(out.Stdout, "Revision", revName, "deleted", "namespace", r.KnTest().Kn().Namespace())) r.AssertNoError(out) }