knative
/
client
mirror of https://github.com/knative/client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

e2e: Foreground delete for revisions and services in e2e (#794) 

* e2e: Foreground delete for revisions and services in e2e

 to avoid any race conditions and flakes

* Use --wait instead of --no-wait=false
This commit is contained in:
Navid Shaikh 2020-04-15 06:50:47 +05:30 committed by GitHub
parent 46ecdcc32f
commit 48f4359b24
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/e2e/basic_workflow_test.go
View File

@ -131,7 +131,7 @@ func serviceUpdate(r *test.KnRunResultCollector, serviceName string, args ...str
} }
func serviceDelete(r *test.KnRunResultCollector, serviceName string) { func serviceDelete(r *test.KnRunResultCollector, serviceName string) {
out := r.KnTest().Kn().Run("service", "delete", serviceName) out := r.KnTest().Kn().Run("service", "delete", "--wait", serviceName)
r.AssertNoError(out) r.AssertNoError(out)
assert.Check(r.T(), util.ContainsAll(out.Stdout, "Service", serviceName, "successfully deleted in namespace", r.KnTest().Kn().Namespace())) assert.Check(r.T(), util.ContainsAll(out.Stdout, "Service", serviceName, "successfully deleted in namespace", r.KnTest().Kn().Namespace()))
} }

2
test/e2e/revision_test.go
View File

@ -98,7 +98,7 @@ func revisionListWithService(r *test.KnRunResultCollector, serviceNames ...strin
} }
func revisionDelete(r *test.KnRunResultCollector, revName string) { func revisionDelete(r *test.KnRunResultCollector, revName string) {
out := r.KnTest().Kn().Run("revision", "delete", revName) out := r.KnTest().Kn().Run("revision", "delete", "--wait", revName)
assert.Check(r.T(), util.ContainsAll(out.Stdout, "Revision", revName, "deleted", "namespace", r.KnTest().Kn().Namespace())) assert.Check(r.T(), util.ContainsAll(out.Stdout, "Revision", revName, "deleted", "namespace", r.KnTest().Kn().Namespace()))
r.AssertNoError(out) r.AssertNoError(out)
} }