knative
/
client
mirror of https://github.com/knative/client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(e2e): Run eventing e2e tests only against nightly and fix service export tests (#1046) 

* fix(e2e): Run eventing e2e tests only against master

* fix(e2e): [service export] Service links are disabled by default

 see https://github.com/knative/serving/pull/9685
This commit is contained in:
Navid Shaikh 2020-10-06 21:47:21 +05:30 committed by GitHub
parent 5025137f5a
commit 6baab2eda4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/e2e/service_export_test.go
View File

@ -45,9 +45,10 @@ type expectedKNExportOption func(*clientv1alpha1.Export)
type podSpecOption func(*corev1.PodSpec) type podSpecOption func(*corev1.PodSpec)
func TestServiceExport(t *testing.T) { func TestServiceExport(t *testing.T) {
//FIXME: enable once 0.18 is available //FIXME: enable once 0.19 is available
if strings.HasPrefix(os.Getenv("KNATIVE_SERVING_VERSION"), "0.17") { // see: https://github.com/knative/serving/pull/9685
t.Skip("The test is skipped on Serving version 0.17") if strings.HasPrefix(os.Getenv("KNATIVE_SERVING_VERSION"), "0.18") {
t.Skip("The test is skipped on Serving version 0.18")
} }
t.Parallel() t.Parallel()
it, err := test.NewKnTest() it, err := test.NewKnTest()
@ -502,6 +503,8 @@ func getPodSpecWithOptions(options ...podSpecOption) corev1.PodSpec {
for _, fn := range options { for _, fn := range options {
fn(&spec) fn(&spec)
} }
// Service links are disabled by default now see https://github.com/knative/serving/pull/9685
spec.EnableServiceLinks = ptr.Bool(false)
return spec return spec
} }

2
test/presubmit-integration-tests-latest-release.sh
View File

@ -18,6 +18,6 @@
# integration tests against Knative Serving / Eventing of a specific version. # integration tests against Knative Serving / Eventing of a specific version.
export KNATIVE_SERVING_VERSION="0.18.0" export KNATIVE_SERVING_VERSION="0.18.0"
export KNATIVE_EVENTING_VERSION="0.18.0" #export KNATIVE_EVENTING_VERSION="0.18.0"
$(dirname $0)/presubmit-tests.sh --integration-tests $(dirname $0)/presubmit-tests.sh --integration-tests