knative
/
client
mirror of https://github.com/knative/client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unused variables and unreachable code (#779)

This commit is contained in:
Navid Shaikh 2020-04-07 02:56:59 +05:30 committed by GitHub
parent a7ec5209dc
commit 8a60d2ebf8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/eventing/v1alpha1/client.go
View File

@ -62,7 +62,7 @@ func NewKnEventingClient(client client_v1alpha1.EventingV1alpha1Interface, names
//CreateTrigger is used to create an instance of trigger //CreateTrigger is used to create an instance of trigger
func (c *knEventingClient) CreateTrigger(trigger *v1alpha1.Trigger) error { func (c *knEventingClient) CreateTrigger(trigger *v1alpha1.Trigger) error {
trigger, err := c.client.Triggers(c.namespace).Create(trigger) _, err := c.client.Triggers(c.namespace).Create(trigger)
if err != nil { if err != nil {
return kn_errors.GetError(err) return kn_errors.GetError(err)
} }
@ -112,7 +112,7 @@ func (c *knEventingClient) ListTriggers() (*v1alpha1.TriggerList, error) {
//CreateTrigger is used to create an instance of trigger //CreateTrigger is used to create an instance of trigger
func (c *knEventingClient) UpdateTrigger(trigger *v1alpha1.Trigger) error { func (c *knEventingClient) UpdateTrigger(trigger *v1alpha1.Trigger) error {
trigger, err := c.client.Triggers(c.namespace).Update(trigger) _, err := c.client.Triggers(c.namespace).Update(trigger)
if err != nil { if err != nil {
return kn_errors.GetError(err) return kn_errors.GetError(err)
} }

1
pkg/kn/commands/describe.go
View File

@ -158,7 +158,6 @@ func sortConditions(conditions []apis.Condition) []apis.Condition {
default: default:
return false return false
} }
return false
}) })
return ret return ret
} }

4
pkg/sources/v1alpha2/binding_client.go
View File

@ -66,7 +66,7 @@ func newKnSinkBindingClient(client clientv1alpha2.SinkBindingInterface, namespac
//CreateSinkBinding is used to create an instance of binding //CreateSinkBinding is used to create an instance of binding
func (c *knBindingClient) CreateSinkBinding(binding *v1alpha2.SinkBinding) error { func (c *knBindingClient) CreateSinkBinding(binding *v1alpha2.SinkBinding) error {
binding, err := c.client.Create(binding) _, err := c.client.Create(binding)
if err != nil { if err != nil {
return knerrors.GetError(err) return knerrors.GetError(err)
} }
@ -116,7 +116,7 @@ func (c *knBindingClient) ListSinkBindings() (*v1alpha2.SinkBindingList, error)
//CreateSinkBinding is used to create an instance of binding //CreateSinkBinding is used to create an instance of binding
func (c *knBindingClient) UpdateSinkBinding(binding *v1alpha2.SinkBinding) error { func (c *knBindingClient) UpdateSinkBinding(binding *v1alpha2.SinkBinding) error {
binding, err := c.client.Update(binding) _, err := c.client.Update(binding)
if err != nil { if err != nil {
return knerrors.GetError(err) return knerrors.GetError(err)
} }