knative
/
client
mirror of https://github.com/knative/client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unusable `--broker` flag from `trigger update` cmd (#1847) 

* Remove unusable  flag from  cmd

* Fix unit test
This commit is contained in:
David Simansky 2023-08-16 13:39:41 +02:00 committed by GitHub
parent 2cdfd1f0da
commit 9676e46c63
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/cmd/kn_trigger_update.md
View File

@ -24,7 +24,6 @@ kn trigger update NAME
### Options ### Options
``` ```
--broker string Name of the Broker which the trigger associates with. (default "default")
--filter strings Key-value pair for exact CloudEvent attribute matching against incoming events, e.g type=dev.knative.foo --filter strings Key-value pair for exact CloudEvent attribute matching against incoming events, e.g type=dev.knative.foo
-h, --help help for update -h, --help help for update
-n, --namespace string Specify the namespace to operate in. -n, --namespace string Specify the namespace to operate in.

5
pkg/kn/commands/trigger/update_flags.go
View File

@ -50,7 +50,10 @@ func (f *TriggerUpdateFlags) GetUpdateFilters() (map[string]string, []string, er
// Add is to set parameters // Add is to set parameters
func (f *TriggerUpdateFlags) Add(cmd *cobra.Command) { func (f *TriggerUpdateFlags) Add(cmd *cobra.Command) {
cmd.Flags().StringVar(&f.Broker, "broker", "default", "Name of the Broker which the trigger associates with.") if cmd.Name() != "update" {
// Spec.Broker is immutable field
cmd.Flags().StringVar(&f.Broker, "broker", "default", "Name of the Broker which the trigger associates with.")
}
// The Sugar controller was integrated into main Eventing controller. With that the default behavior was changed as well. // The Sugar controller was integrated into main Eventing controller. With that the default behavior was changed as well.
// Users need to configure 'Automatic Broker Creation' per linked docs. // Users need to configure 'Automatic Broker Creation' per linked docs.
// Deprecated in 1.4, remove in 1.6. // Deprecated in 1.4, remove in 1.6.

14
pkg/kn/commands/trigger/update_test.go
View File

@ -62,20 +62,6 @@ func TestTriggerUpdateWithError(t *testing.T) {
eventingRecorder.Validate() eventingRecorder.Validate()
} }
func TestTriggerUpdateInvalidBroker(t *testing.T) {
eventingClient := clienteventingv1.NewMockKnEventingClient(t)
eventingRecorder := eventingClient.Recorder()
present := createTrigger("default", triggerName, map[string]string{"type": "dev.knative.new"}, "mybroker", "newsvc")
eventingRecorder.GetTrigger(triggerName, present, nil)
out, err := executeTriggerCommand(eventingClient, nil, "update", triggerName,
"--broker", "newbroker")
assert.ErrorContains(t, err, "broker is immutable")
assert.Assert(t, util.ContainsAll(out, "Usage", triggerName))
eventingRecorder.Validate()
}
func TestTriggerUpdateDeletionTimestampNotNil(t *testing.T) { func TestTriggerUpdateDeletionTimestampNotNil(t *testing.T) {
eventingClient := clienteventingv1.NewMockKnEventingClient(t) eventingClient := clienteventingv1.NewMockKnEventingClient(t)