knative
/
client
mirror of https://github.com/knative/client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore(wait): Fixes for Smoke Tests + help messages (#250) 

* Increase wait timeout to 240s (to avoid test failures like in https://storage.googleapis.com/knative-prow/pr-logs/pull/knative_client/244/pull-knative-client-integration-tests-latest-release/1148472118510358531/build-log.txt)
* Fixed duplicate default help message for `kn service create --help`
This commit is contained in:
Roland Huß 2019-07-10 22:36:12 +02:00 committed by Knative Prow Robot
parent e1614f95e6
commit 9fb6a436e8
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/cmd/kn_service_create.md
View File

@ -54,7 +54,7 @@ kn service create NAME --image IMAGE [flags]
-p, --port int32 The port where application listens on. -p, --port int32 The port where application listens on.
--requests-cpu string The requested CPU (e.g., 250m). --requests-cpu string The requested CPU (e.g., 250m).
--requests-memory string The requested memory (e.g., 64Mi). --requests-memory string The requested memory (e.g., 64Mi).
--wait-timeout int Seconds to wait before giving up on waiting for service to be ready (default: 60). (default 60) --wait-timeout int Seconds to wait before giving up on waiting for service to be ready. (default 60)
``` ```
### Options inherited from parent commands ### Options inherited from parent commands

2
pkg/kn/commands/wait_flags.go
View File

@ -36,6 +36,6 @@ func (p *WaitFlags) AddConditionWaitFlags(command *cobra.Command, waitTimeoutDef
waitUsage := fmt.Sprintf("Create %s and don't wait for it to become ready.", what) waitUsage := fmt.Sprintf("Create %s and don't wait for it to become ready.", what)
command.Flags().BoolVar(&p.Async, "async", false, waitUsage) command.Flags().BoolVar(&p.Async, "async", false, waitUsage)
timeoutUsage := fmt.Sprintf("Seconds to wait before giving up on waiting for %s to be ready (default: %d).", what, waitTimeoutDefault) timeoutUsage := fmt.Sprintf("Seconds to wait before giving up on waiting for %s to be ready.", what)
command.Flags().IntVar(&p.TimeoutInSeconds, "wait-timeout", waitTimeoutDefault, timeoutUsage) command.Flags().IntVar(&p.TimeoutInSeconds, "wait-timeout", waitTimeoutDefault, timeoutUsage)
} }

2
test/e2e-smoke-tests.sh
View File

@ -47,7 +47,7 @@ header "Running smoke tests"
kubectl create ns $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test kubectl create ns $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test
./kn service create svc1 --async --image gcr.io/knative-samples/helloworld-go -e TARGET=Knative -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test ./kn service create svc1 --async --image gcr.io/knative-samples/helloworld-go -e TARGET=Knative -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test
./kn service create hello --image gcr.io/knative-samples/helloworld-go -e TARGET=Knative -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test ./kn service create hello --image gcr.io/knative-samples/helloworld-go -e TARGET=Knative -n $KN_E2E_SMOKE_TESTS_NAMESPACE --wait-timeout 240 || fail_test
./kn service list hello -n $KN_E2E_SMOKE_TESTS_NAMESPACE -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test ./kn service list hello -n $KN_E2E_SMOKE_TESTS_NAMESPACE -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test
./kn service update hello --env TARGET=kn -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test ./kn service update hello --env TARGET=kn -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test
./kn revision list hello -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test ./kn revision list hello -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test