knative
/
client
mirror of https://github.com/knative/client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix for the failure of trigger e2e test (#690)

This commit is contained in:
Ying Chun Guo 2020-02-28 18:36:51 +08:00 committed by GitHub
parent d14c01fb5d
commit ab00cc2969
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/e2e/trigger_test.go
View File

@ -40,6 +40,8 @@ func TestBrokerTrigger(t *testing.T) {
err = test.lableNamespaceForDefaultBroker(t) err = test.lableNamespaceForDefaultBroker(t)
assert.NilError(t, err) assert.NilError(t, err)
defer test.unlableNamespaceForDefaultBroker(t)
test.serviceCreate(t, r, "sinksvc0") test.serviceCreate(t, r, "sinksvc0")
test.serviceCreate(t, r, "sinksvc1") test.serviceCreate(t, r, "sinksvc1")
@ -47,6 +49,8 @@ func TestBrokerTrigger(t *testing.T) {
test.triggerCreate(t, r, "trigger1", "sinksvc0", []string{"a=b"}) test.triggerCreate(t, r, "trigger1", "sinksvc0", []string{"a=b"})
test.triggerCreate(t, r, "trigger2", "sinksvc1", []string{"type=knative.dev.bar", "source=cronjob"}) test.triggerCreate(t, r, "trigger2", "sinksvc1", []string{"type=knative.dev.bar", "source=cronjob"})
test.verifyTriggerList(t, r, "trigger1", "trigger2") test.verifyTriggerList(t, r, "trigger1", "trigger2")
test.triggerDelete(t, r, "trigger1")
test.triggerDelete(t, r, "trigger2")
t.Log("create a trigger and delete it") t.Log("create a trigger and delete it")
test.triggerCreate(t, r, "deltrigger", "sinksvc0", []string{"a=b"}) test.triggerCreate(t, r, "deltrigger", "sinksvc0", []string{"a=b"})
@ -58,11 +62,19 @@ func TestBrokerTrigger(t *testing.T) {
test.verifyTriggerDescribe(t, r, "updtrigger", "default", "sinksvc0", []string{"a", "b"}) test.verifyTriggerDescribe(t, r, "updtrigger", "default", "sinksvc0", []string{"a", "b"})
test.triggerUpdate(t, r, "updtrigger", "type=knative.dev.bar", "sinksvc1") test.triggerUpdate(t, r, "updtrigger", "type=knative.dev.bar", "sinksvc1")
test.verifyTriggerDescribe(t, r, "updtrigger", "default", "sinksvc1", []string{"a", "b", "type", "knative.dev.bar"}) test.verifyTriggerDescribe(t, r, "updtrigger", "default", "sinksvc1", []string{"a", "b", "type", "knative.dev.bar"})
test.triggerDelete(t, r, "updtrigger")
t.Log("create trigger with error return") t.Log("create trigger with error return")
test.triggerCreateMissingSink(t, r, "errtrigger", "notfound") test.triggerCreateMissingSink(t, r, "errtrigger", "notfound")
} }
func (test *e2eTest) unlableNamespaceForDefaultBroker(t *testing.T) {
_, err := kubectl{}.Run("label", "namespace", test.kn.namespace, "knative-eventing-injection-")
if err != nil {
t.Fatalf("Error executing 'kubectl label namespace %s knative-eventing-injection-'. Error: %s", test.kn.namespace, err.Error())
}
}
func (test *e2eTest) lableNamespaceForDefaultBroker(t *testing.T) error { func (test *e2eTest) lableNamespaceForDefaultBroker(t *testing.T) error {
_, err := kubectl{}.Run("label", "namespace", test.kn.namespace, "knative-eventing-injection=enabled") _, err := kubectl{}.Run("label", "namespace", test.kn.namespace, "knative-eventing-injection=enabled")
if err != nil { if err != nil {