knative
/
client
mirror of https://github.com/knative/client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update common github actions (#1198) 

Signed-off-by: Knative Automation <automation@knative.team>
This commit is contained in:
knative-automation 2021-01-21 06:38:53 -08:00 committed by GitHub
parent 31496f4712
commit eda6a844ed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
.github/workflows/knative-style.yaml vendored
View File

@ -141,7 +141,12 @@ jobs:
echo '::group:: Running github.com/client9/misspell with reviewdog 🐶 ...' echo '::group:: Running github.com/client9/misspell with reviewdog 🐶 ...'
# Don't fail because of misspell # Don't fail because of misspell
set +o pipefail set +o pipefail
find . -type f -not -path './vendor/*' -not -path './third_party/*' -not -path './.git/*' | # Exclude generated and vendored files, plus some legacy
# paths until we update all .gitattributes
git ls-files |
git check-attr --stdin linguist-generated | grep -Ev ': (set|true)$' | cut -d: -f1 |
git check-attr --stdin linguist-vendored | grep -Ev ': (set|true)$' | cut -d: -f1 |
grep -Ev '^(vendor/|third_party/|.git)' |
xargs misspell -error | xargs misspell -error |
reviewdog -efm="%f:%l:%c: %m" \ reviewdog -efm="%f:%l:%c: %m" \
-name="github.com/client9/misspell" \ -name="github.com/client9/misspell" \
@ -164,7 +169,13 @@ jobs:
echo '::group:: Flagging trailing whitespace with reviewdog 🐶 ...' echo '::group:: Flagging trailing whitespace with reviewdog 🐶 ...'
# Don't fail because of grep # Don't fail because of grep
set +o pipefail set +o pipefail
find . -type f -not -path './vendor/*' -not -path './third_party/*' -not -path './.git/*' |
# Exclude generated and vendored files, plus some legacy
# paths until we update all .gitattributes
git ls-files |
git check-attr --stdin linguist-generated | grep -Ev ': (set|true)$' | cut -d: -f1 |
git check-attr --stdin linguist-vendored | grep -Ev ': (set|true)$' | cut -d: -f1 |
grep -Ev '^(vendor/|third_party/|.git)' |
xargs grep -nE " +$" | xargs grep -nE " +$" |
reviewdog -efm="%f:%l:%m" \ reviewdog -efm="%f:%l:%m" \
-name="trailing whitespace" \ -name="trailing whitespace" \
@ -192,7 +203,13 @@ jobs:
# - nothing in third_party # - nothing in third_party
# - nothing in .git/ # - nothing in .git/
# - no *.ai (Adobe Illustrator) files. # - no *.ai (Adobe Illustrator) files.
for x in $(find . -type f -not -name '*.ai' -not -path './vendor/*' -not -path './third_party/*' -not -path './.git/*'); do LINT_FILES=$(git ls-files |
git check-attr --stdin linguist-generated | grep -Ev ': (set|true)$' | cut -d: -f1 |
git check-attr --stdin linguist-vendored | grep -Ev ': (set|true)$' | cut -d: -f1 |
grep -Ev '^(vendor/|third_party/|.git)' |
grep -v '\.ai$')
for x in $LINT_FILES; do
# Based on https://stackoverflow.com/questions/34943632/linux-check-if-there-is-an-empty-line-at-the-end-of-a-file # Based on https://stackoverflow.com/questions/34943632/linux-check-if-there-is-an-empty-line-at-the-end-of-a-file
if [[ -f $x && ! ( -s "$x" && -z "$(tail -c 1 $x)" ) ]]; then if [[ -f $x && ! ( -s "$x" && -z "$(tail -c 1 $x)" ) ]]; then
# We add 1 to `wc -l` here because of this limitation (from the man page): # We add 1 to `wc -l` here because of this limitation (from the man page):