knative
/
client
mirror of https://github.com/knative/client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: Update CRDs API version to v1 (#1248) 

* chore: Update CRDs API version to v1

* fix: Fix e2e test

* chore: Add changelog entry
This commit is contained in:
David Simansky 2021-03-04 11:23:15 +01:00 committed by GitHub
parent 270e322401
commit ffe385a34e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
CHANGELOG.adoc
View File

@ -12,6 +12,17 @@
| https://github.com/knative/client/pull/[#] | https://github.com/knative/client/pull/[#]
//// ////
## (Unreleased)
[cols="1,10,3", options="header", width="100%"]
|===
| | Description | PR
| ✨
| Update CRDs API version to `v1`
| https://github.com/knative/client/issues/1248[#1248]
|===
## v0.21.0 (2021-02-23) ## v0.21.0 (2021-02-23)
[cols="1,10,3", options="header", width="100%"] [cols="1,10,3", options="header", width="100%"]
|=== |===

2
pkg/dynamic/client.go
View File

@ -31,7 +31,7 @@ import (
const ( const (
crdGroup = "apiextensions.k8s.io" crdGroup = "apiextensions.k8s.io"
crdVersion = "v1beta1" crdVersion = "v1"
crdKind = "CustomResourceDefinition" crdKind = "CustomResourceDefinition"
crdKinds = "customresourcedefinitions" crdKinds = "customresourcedefinitions"
sourcesLabelKey = "duck.knative.dev/source" sourcesLabelKey = "duck.knative.dev/source"

2
pkg/kn/commands/channel/list_types_test.go
View File

@ -36,7 +36,7 @@ import (
const ( const (
crdGroup = "apiextensions.k8s.io" crdGroup = "apiextensions.k8s.io"
crdVersion = "v1beta1" crdVersion = "v1"
crdKind = "CustomResourceDefinition" crdKind = "CustomResourceDefinition"
testNamespace = "current" testNamespace = "current"
channelLabelValue = "true" channelLabelValue = "true"

2
pkg/kn/commands/source/list_test.go
View File

@ -31,7 +31,7 @@ import (
const ( const (
crdGroup = "apiextensions.k8s.io" crdGroup = "apiextensions.k8s.io"
crdVersion = "v1beta1" crdVersion = "v1"
crdKind = "CustomResourceDefinition" crdKind = "CustomResourceDefinition"
sourcesLabelKey = "duck.knative.dev/source" sourcesLabelKey = "duck.knative.dev/source"
sourcesLabelValue = "true" sourcesLabelValue = "true"

2
test/e2e/source_list_test.go
View File

@ -44,7 +44,7 @@ func TestSourceListTypes(t *testing.T) {
t.Log("List available source types in YAML format") t.Log("List available source types in YAML format")
output = sourceListTypes(r, "-oyaml") output = sourceListTypes(r, "-oyaml")
assert.Check(t, util.ContainsAll(output, "apiextensions.k8s.io/v1beta1", "CustomResourceDefinition", "Ping", "ApiServer")) assert.Check(t, util.ContainsAll(output, "apiextensions.k8s.io/v1", "CustomResourceDefinition", "Ping", "ApiServer"))
} }
func TestSourceList(t *testing.T) { func TestSourceList(t *testing.T) {