* update to k8s 0.19.7, go v1.15, fix gnostic
* oops, did not run ./hack/build.sh
* Fix unit tests that broke because of k8s 1.19 update
* Update asserting in test to adapt to new jsonpath output behaviour
Looks like that strings are quoted now in arrays.
* fix one more assert
Co-authored-by: Roland Huß <roland@ro14nd.de>
bumping knative.dev/pkg 32a3248...7101e9d:
> 7101e9d allow the addressable ducktype to act as an ownerref (# 1999)
> 250a183 Bump K8s libs to 1.19 (# 1986)
> 2f4dd35 Switch Webhook to ed25519 and expiration of the certificate to seven days (# 1998)
bumping knative.dev/serving d0a0e38...e61294b:
> e61294b Implement e2e test for the gradual rollout. (# 10610)
> ea79db1 Improve test flow (# 10611)
> c369980 don't add the UID labels since it breaks downgrading (# 10615)
> 16dc14f Rever the 100ms to 1ms change, since it flakes a lot (# 10609)
> df43d82 Remove some -1 here and there and compute it once. (# 10604)
> b6e0ad5 Update net-istio nightly (# 10607)
> 8e3abe8 Update net-certmanager nightly (# 10598)
> 4437522 Replace arbitrary short sleeps with short-circuited long sleeps (# 10608)
> 9c9b7bb Add julz to API reviewers (# 10606)
> 076d97c Make TestHTTPProbeTimeoutFailure more reliable (# 10605)
bumping knative.dev/eventing 26a3bfa...ff327f0:
> ff327f0 Expose the function RunMainTest (# 4779)
> c4a39e2 test(sources): add roundtrip tests for sources v1 types (# 4764)
> ebd5b0f Allow to specify build platform for test images (# 4763)
> 7123f45 Use KO_YAML_FLAGS for multi-platform build (# 4770)
bumping knative.dev/networking 4db00b8...8b522a9:
> 8b522a9 Move TestProbeHeaders tests to stable, TestTagHeaders tests to beta (# 340)
Signed-off-by: Knative Automation <automation@knative.team>
bumping knative.dev/eventing a414aee...1c94ef8:
> 1c94ef8 Add event reply header to spec (# 4560)
> 056bc25 Add Open Telemetry Spec attributes to IMC Dispatcher span (# 4659)
> 6d76c44 try using hack wait for pods (# 4741)
> d74dc25 Format markdown (# 4740)
> 1897543 [# 4717] Update e2e broker defaults webhook test (# 4720)
> c5b9eeb Unify usage of YAML libraries (# 4667)
> 2e96fd0 Now the config-imc-event-dispatcher values are injected to the dispatcher through envs (# 4543)
> 05a3a27 note that these only pertain to this repo (# 4733)
> 21d91e4 Format markdown (# 4734)
> 47d9937 Update spec.md with v1 API (# 4594)
> 343dec3 Use the v1 api package... (# 4727)
> ff5109d re-submit # 4707 (# 4730)
> b1882d6 [# 4721] Update e2e broker default webhook test (# 4722)
> 7d12333 Disabling servicelinks in all the components (# 4714)
bumping knative.dev/networking ecb89ce...07a8160:
> 07a8160 upgrade to latest dependencies (# 331)
> 4c4c237 Add config to disable auto-creation of domain claims (# 330)
> 3a89509 As per discussion with @mattmoor keep drainer in pkg (# 329)
> c30dc94 Use symlink for testdata version of config-network.yaml (# 328)
bumping knative.dev/hack 4ed1ecb...4422dca:
> 4422dca Set GOBIN in codegen-library.sh (# 44)
> d946d25 Revert "Add hermetic go mod aware handling to run_go_tool (# 38)" (# 39)
> ea9c9a0 Add hermetic go mod aware handling to run_go_tool (# 38)
bumping knative.dev/serving 560a4f6...84421cd:
> 84421cd Shutdown processor to avoid log races (# 10544)
> e402e8e Remove the old constant since the new one has been since August 2020 (# 10559)
> 89cbb09 Nits in the code formatting (# 10558)
> c06ee54 Move the functions that have only single use to the private package (# 10541)
> cf06222 Remove activator/util package (# 10557)
> 95c699b Update net-certmanager nightly (# 10551)
> bcbaa8e Update net-contour nightly (# 10553)
> c865fa5 Un-export WithRevID, RevIDFrom, WithRevision, RevisionFrom (# 10549)
> 824e336 Cut down queue-probe test time from 3s to .5s (# 10548)
> 725cbe9 Fix wrong file permission (# 10543)
> e07174d Use explicit revID parameter in Throttler (# 10545)
> 454fd7c Allow disabling of automatic DomainClaim creation (# 10537)
> 1f95e13 Remove comment about recreation of the autoscaler pod in config-logging (# 10542)
> 0f2d350 swap dates with tcnghia (# 10529)
> 156f8a4 upgrade to latest dependencies (# 10538)
> c886a22 Simplify and optimise proxy header pruning (# 10535)
> 7602d81 Remove backwards compatibility check in KPA (# 10534)
> d28e461 Sanitize probe header value written by user before response (# 10533)
> e2c6836 Ensure step size is validated and add tests (# 10532)
> ca1ac91 Update net-istio nightly (# 10524)
> 3ec271c Improve performance a bit by using binary search (# 10531)
> 8f213d9 Report first and second revision metrics separately and deleted old rev. (# 10518)
> 457be78 Update net-contour nightly (# 10523)
> a295b6d Update net-certmanager nightly (# 10522)
bumping knative.dev/pkg 51c72e2...f0ea5e6:
> f0ea5e6 Use special error type to designate skips. (# 1988)
> acbf2af Harden logstream against non-object events (# 1984)
> 93874f0 Drainer supports customized kubelet probe check (# 1977)
Signed-off-by: Knative Automation <automation@knative.team>
* Update deps for release v0.20.0
* Update version command
* Update CHANGELOG
* Run tests against serving and eventing v0.20.0
* Run tests against serving and eventing v0.20.0
* feat: "kn service apply"
This commit introduces a client-side apply with a plain JsonPatchMerge. This is more limited than a StrategicPatchMerg as it does not allow to merge lists (they are just overwritten). Also is not a real 3-way merger that would lead to a conflict when both the, the server-side and the provide update overlapp in fields that updated, compared to the shared original configuration. This is a problem of JsonThreeWayMerger itself, as pointed out in https://github.com/kubernetes/kubernetes/pull/40666#pullrequestreview-502804243.
This limitation is shared with kubectl, which suffers from the same issue if using `kubectl apply` with a custom resource (i.e. with everything that has schema that is not registered within kubectl).
Tests are missing, too, but will come soon
* chore: Add tests for 'kn apply'
* refactor: Removed PatchService from pulic API interface
* fix: Display of service URL at the end, when no changes apply
* chore: Add initial E2E test
* chore: Implemented review suggestions
* More tests
* Example for kn service apply
* Remove commented-out code
* lint fixes
* fix formatting of kn service apply doc
* fixing go.sum
* chore: Update deps
* updating to use the hack repo
* eof
* you need to run update deps after codegen to pick up any new deps.
* do not reinvent update-deps.
* must be winter
* Update autoscaling annotation validation
see ref: https://github.com/knative/serving/pull/9496
* Replace DeprecatedInjectionAnnotation with InjectionAnnotation
* Vendor deps at master
* Use context.TODO instead of context.Background
* Pin pkg to release-0.18 version
* ./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh
* bump k8s version to 1.18.8
* Fix the brokerage of importing latest serving
* exclude script/test-infra md from md check
* chore: Add support for internal plugins
* added test for internal plugin lookup
* add changelog entry
* fix formatting
* update to latest changes on main
* Added more tests + some docs
* formatting fix
* moved to proper injection label for setting up the broker in integration test
* Pin spf13/cobra dep at b95db644ed1c0e183a90d8509ef2f9a5d51cc29b
which includes the zsh completion fix for https://github.com/spf13/cobra/pull/899
and remove the fork of cobra with fix in `replace` section of go.mod
* Parse args without invoking a separate command
Do not define and execute extractCommand before running actual root
command to parse all the args without flags. This was creating issues
with completion utils to generate additional shell completion directive.
Now uses cobra's inbuilt utilities to parse the command args without flags.
* Return error from stripFlags if any
* Update unit tests
* Update unit test for invalid concurrency target value
* Vendor v0.16.0 eventing and serving
* Commit the LICENSES generated by hack/update-deps.sh
* Spare third_party dir from license check in hack/build.sh
* Update eventing and serving version for 'kn version'
* Use DeprecatedInjectionAnnotation key for backward compatibility
Fixes#918
Use DeprecatedInjectionAnnotation, i.e. "knative-eventing-injection"
for reconciling broker via namespace labeling and trigger annotations.
From eventing v0.16.0 release, this key is changed to "eventing.knative.dev/injection"
however, older eventing installation wont recognize it. So we continue
using the deprecated key until the sugar-controller would support reconciling
on either keys.
* Fix(kn version): Display eventing.knative.dev at v1beta1 version
We've been showing 'v1alpha1' in kn version while we actually
vendor and refer v1beta1 for eventing.knative.dev
* chore(e2e): Run tests against serving/eventing v0.16.0 release
* Update test for concurrency-target to expect new error message
the new error message for incorrect concurrency-target value contains "should be at least 0.01"
* Setup sugar-controller for released eventing version setup
- reuse knative_setup util from common lib for latest-release CI setup
* Fix typo in YAML URL and add subheader for sugar-controller install
* add kn export type
* add kn export type
* add kn export type
* Update pkg/apis/client/register.go
Co-authored-by: Matt Moore <mattmoor@vmware.com>
* e2e test for kn export type
* e2e test for kn export type
* add new type for kn export
* rebase
* rebase
Co-authored-by: Roland Huß <rhuss@redhat.com>
Co-authored-by: Matt Moore <mattmoor@vmware.com>
Co-authored-by: Roland Huß <roland@ro14nd.de>
* chore: Update to Knative serving/eventing 0.14.0
and also move ApiServerSource to v1alpha2, adapting the option
(from "controller" to "labelSelector")
* fix go.sum
* chore: Update and fix tests
* chore: fix go.sum
* (refactor) address the e2e extract / refactor of issue #763
* various updates to address reviewers feedback
* renamed lib/test/integration to lib/test and package to test
The check of the maximum for concurrency-limit had to be removed as
this is picked up now also from the server side configuration
to which we don't have access. Checking against the default
max is misleading and contra-productive if this could be
different when configured differently by the Knative administrator.
* chore(e2e): Optimized tests
Smoke Tests now run before the E2E tests, but in the same cluster
* chore: Removed unneeded test
* fix
* fix
* fix
* fix
* chore: Update to serving & eventing v0.13.0
* refactor(source): Update to Knative eventing 0.13.0
* Moved to "sources.knative.dev" API group
* Replaced CronJobSource with PingSource (and removed unsupported options for service account, requests limits)
* Move to versions:
- SinkBinding v1alpha2
- PingSource v1alpha2
- ApiServerSource v1alpha1
* update to eventing 0.13.1
* go.sum fix
* fixed test
* test updates
* try to enhance error output
* fix test.
* update tests infra to 0.13.1
* chore(e2e): Refactor e2e to better track errors
* Collect results from various `kn` calls to
provide the context
* Changed sub-Run() commands to t.Log() to reduce
the log noise and get file + line information
in the log output
* Removed any Fatal() calls to allows the test
to properly finish
* Only output via t.Log() to get the output at the
proper places and allow Prow to better pick
up the test results.
* Most important: EMOJIS !! 🦆🦆🦆🦆🦆
* chore(e2e): Add more dumpers
* Moar debug
* feature(serving): Update API to serving.knative.dev/v1
Due to an issue with 0.12.0 (a missing constant) the update also includes an update
to the latest knative-serving and knative-eventing dependencies from master
(as reflected in version.go)
Signed-off-by: Roland Huß <roland@ro14nd.de>
* fix(serving): Bogus import removed
* fix(serving): Add missing go.sum entry
* feature(source cronjobs): Implementation of CronJobSource management
Contains create/delete/update/describe but not tests yet.
Still todo:
* Think how to provide a namespace for the sink
* Support for more sinks
* Synchronous mode for create & update
* Add list (or implement "source list")
* chore: Add a mock test for cronjob source
* addd missing license headers
* cosmetic changes
* chore(cronjobsource): Add tests
* fixup
* chore(cronjob source): Improved test coverage
* chore(cronjob source): some review polishing
- Pin contrib.go.opencensus.io/exporter/stackdriver@59d068f8d8ff5b653916aa30cdc4e13c7f15d56e
- Pin knative.dev/pkg@release-0.11
- Move `Destination` from (knative.dev/pkg) v1alpha1 to duckv1beta1
- Run tests against Eventing v0.11.0
* Eventing setup in CI
- Update test-infra
- Use library functions for setting up released and latest Eventing
- Set up Eventing 0.10.2 and nightly release in `latest-release` and default e2e tests CI job respectively
* Fix typo in variable name and update formatting
* Updates spf13/cobra dep to v0.0.5
Fixes#426
- and a couple of patches on top which aren't merged yet
- spf13/cobra#884
- spf13/cobra#899
- also updates viper to 1.4.0
* Updates to go.sum
* Updates go.mod
as a result of `go install golang.org/x/tools/cmd/goimports`
* Vendors serving v0.9.0
* Updates references per serving v0.9.0 vendoring
- Updates code and tests to refer the required data structure and method/function calls
- duckv1beta1 -> duckv1 conditions
- traffic percent value is now *int64
- containerConcurrency validation method relocation
* fix(golint): exported function should have comment
for NonReadyConditionReason function
* Updates check for removing null targets
fixes the pointer value check
* Updates per review comments
Fixes#364
- Ensure kn cross platform build works in pre-submit tests
- Run ./hack/build.sh -x after running existing pre-submit tests
- defines a function post_build_tests to invoke cross platform builds
- post_build_tests will be run by test-infra after build tests are compelete
* Update serving to 0.8. Try building.
* Find the right serving version
* Change our own import path to knative.dev to match
* Remove dependency on old version of client
* Update yaml template
* Add sleep to test to deal with race
* fix merge conflict
* Update vendor modules
* feature(service describe): Output of service details
`kn service show` mimics `kubectl describe <sth>` as that it output detail information in human readable output.
A future extension should add machine readable output with `-o` to export
a single object in json/yaml (that is missing from `kn service list`)
This command shows information about the service itself, but also a summary about the associated revisions.
It also knows about scaling and concurrency options.
Options:
`--details` : Print more information. By default only are shorter summary is shown
* chore: Cleanup up and refreshed dependencies
* fix(service describe): Integration test fix (revert "show" to "describe")
* fix: go.sum
* fix go.sum
* feature(service describe): Add printing of resources (requests/limits) + machine readable output with -o
* chore(service describe): Simplified digest handling
* chore(service describe): Sort maps by key when printed
* chore: Adapt mock framework
* chore(service describe): Test fixes
* chore: Added some tests
* more tests
* test: Moar tests
* chore: Even moar tests
* more, more tests
* changelog update
* fix(service describe): golint fixes
* Check that every generated file has been regenerated for CI
* No color when not on a tty which is useful for build logs
* Always do updates when called without args
* Removed -u option and added -c for codegen only (dep update, docs gen, formatting, license check)
* fix(serving): Remove hardcoded GVK and look it up from schema
Fixes#133.
* chore(serving): Add test for "WaitForService()"
* refactor(service): Add listRoutes() to client + generic way for list options
* chore(serving): Fixing rebase conflicts
Explores all sub-commands from root and adds a RunE for all
commands that are groups with child commands and without a RunE.
The added RunE will return the correct errors when the command
is called with empty sub-command or with an unknown sub-command.
It will also print the command help message first.
Added a gotest.tools test for root.go.
* feat(build.sh): Enable goimports for cleanup imports + cleanup imports
Much like 'go fmt' for cleaning up go source, 'goimports' can help
in properly formatting and grouping imports. See https://goinbigdata.com/goimports-vs-gofmt/
for a quick overview.
This commit also cleansup imports on existing files.
* fix(build): Add missing space for output on iterm
* chore(build): Merged gofmt and goimports
And changed order so that formatting and import reordering comes
before compiling and testing
Creates four subpackages for now:
1. kn/commands - inludes types.go for common
struct and other common files and misc commands
2. kn/commands/service - all 'kn service *' commands
3. kn/commands/revision - all 'kn revision *' commands
4. kn/core - contains the root.go and other top level
for code and testing
5. refactors:
a. split .../commons/human_readable_flags.go into three
b. modifies the HumanReadableFlags.ToPrinter to get pass
a function that sets the columns and fields
Had to refactor all tests to avoid cycles.
This requires updating test-infra to deal with a repo that has no releases yet.
Also use hash and dates from the helper, to keep the binary and the GCS dirs in sync.
* chore: Update dependency to knative-serving 0.5.1
* chore: Changed deps to released versions where possible
Rebuilt mod deps and vendor dir based on this dependency list
github.com/knative/serving v0.5.
github.com/knative/pkg v0.0.0-20190330001454-aad7a9ad4639
github.com/mitchellh/go-homedir v1.1.0
github.com/spf13/cobra v0.0.3
github.com/spf13/pflag v1.0.3
github.com/spf13/viper v1.3.1
k8s.io/api kubernetes-1.14.1
k8s.io/apimachinery kubernetes-1.14.1
k8s.io/cli-runtime kubernetes-1.14.1
k8s.io/client-go v11.0.0
sigs.k8s.io/yaml v1.1.0
Not sure if all dependencies are required (e.g. is k8s.io/api required
to be specified explicitely or shouldn't we rely on k8s.io/client-go
to bring it this as a transitive dependency which maches always
the cli-runtime's version.
* chore: Update .gitignore to *not* ignore certain vendor files
* chore: Aligned with k8s version from serving 0.5.2
* chore: Run `go mod tidy`
* chore(modules): Update dependencies
* Added support for limits and requests of CPU and memory. Examples:
1. kn service create mysvc --image dev.local/ns/image:latest --request-cpu 100m --requests-memory 64Mi
2. kn service create mysvc --image dev.local/ns/image:latest --limits-cpu 1000m --limits-memory 1024Mi
You can also include and/or omit the requests and limits. So the following should also work:
kn service create mysvc --image dev.local/ns/image:latest --request-cpu 1000m --limits-memory 1024Mi
* Addressed comments about maintaining existing requests and limits and added more tests
* TestServiceCreateWithRequests
* TestServiceCreateWithLimits
* TestServiceCreateRequestsLimitsCPU
* TestServiceCreateRequestsLimitsMemory
* TestServiceCreateRequestsLimitsCPUMemory
* updating dependencies and formatting tests code
* Stub in an integration test
This just calls `kn service list` and verifies it doesn't have a
non-zero exit status.
* Build the client in pre_integration_tests
* Need to explicitly build the `kn` client
As opposed to just building the entire repo. That didn't actually
stick a `kn` binary in the root.
* Address code review feedback
Build the client in e2e-tests.sh instead of presubmit-tests.sh, fix a
couple copy/paste places that referred to eventing, remove unnecessary
knative_teardown function.
* Don't attempt to build kn twice
* Turns out pre_integration_tests() is the easiest way to build kn
We don't have any other good hooks at the moment to do something in
`e2e-tests.sh` that runs only once before the test cluster gets setup.
* Update test-infra to use the new cluster_setup function
This updates the version of test-infra to use the new cluster_setup
function added in https://github.com/knative/test-infra/pull/667
It simplifies our e2e setup logic into one place instead of being
split over presubmit-tests.sh and e2e-tests.sh
* Update vendored test-infra as well
* We have to explicitly tell CI to use the vendored modules
* Be a bit more descriptive in the stubbed out integration test
When building with go 1.11.5 I see a hash mismatch for knative/serving.
The algorithm for computing the hash has changed in recent go releases.
To create this PR I ran:
- `rm go.sum`
- `go test ./pkg/...`
- `go build ./cmd/kn`
- `go mod tidy`
All developers should update their version of go and clean their module
cache to flush downloaded modules with an invalid hash.
* Refactor commands to allow insertion of fakes for testing
* Pin client-go to version that matches signatures other libs use
* Add tests for service list
* actually add test file
* Review comments: Fatal instead of Error/return, Split instead of read to newline
* Get revision and service listing skeletons in.
This adds the kn program, with basic commands for service and revision listing
in.
kn service list
kn revision list
They use the genericclioptions library from kubernetes to support jsonpath,
yaml, and json output. The default is to just list the names of the objects, for
now, until we add in some of the kubectl-based libraries for creating tables in
another commit.
This is deliberately bare-bones; I am looking to get the basic skeletons of how
this repository is laid out down.
No tests yet. Soon.
* Move commands to pkg, so cmd only contains minimalist main.go
* RunE instead of Run. The defaults on Cobra command generation are weird.
* Oops forgot to change types of stuff
* Do not panic on bad config file
* Make commands no longer global
* Make configuration initialization not static in the module, but rather triggered by main.go init
Ville Aikas