Fixes#507
- removes `--wait-timeout` flag, was set to 240 seconds which is lesser than the default timeout (600 seconds)
- removes duplication of namespace flag in another smoke test command
* refactor delete service unit test with mock kn client (#358)
* refactor list svc unit test with mock kn client (#358)
* refactor list svc unit test with mock kn client (#358)
* fix review comments for pr 527 (#358)
* fix review comments for pr 527 (#358)
- Uses custom `unit_tests` function in presubmit-tests.sh to run unit tests
- Custom function adds a flag `-mod=vendor` in addition to default unit tests runner
- The deps are already downloaded part of the source repo, mentioned flag uses it (vendor dir)
and avoids downloading the deps afresh
- This prevents(in unit tests) the flake we see 'go: error loading module requirements' which occurs
due to download error
Related to #500
- The fix for serving#6060 merged (serving#6069), removing the workaround
at client side e2e tests for additional LCR=LRR check after service update return.
- Now we expect service status to have LCR=LRR if the service's conditions turned True after last update.
- This changeset updates serving version for pull-knative-client-integration-tests-latest-release
- Serving nightly release is tested in prow job pull-knative-client-integration-tests
* chore: Add version information of eventing
Adding sources.eventing.knative.dev to version info (the only eventing API)
for now as this will be the first one used.
* chore(version): Add grouping for API versions
* Uses BYO revision names for traffic splitting e2e tests
- Avoid getting the revision name after service create/update using LCR or LRR from service status
* Pauses 3 seconds before verifying actual vs expected traffic targets
- for traffic splitting e2e tests
- Check the comment on https://github.com/knative/client/issues/500#issuecomment-554355688
- `./hack/build.sh` performs usual flow of codegen, build and test
- `./hack/build.sh -x` only compiles cross platform
- Updates hack/build.sh help message to reflect this
While testing I specified this on the `kn` command line:
```
./kn service create echo --concurrency-limit=1 --concurrency-target=1 --env foo=bar --limits-cpu=1000m --limits-memory=1024m --max-scale=1 --min-scale=1 --port=9999 --requests-cpu=250m --requests-memory=64mi --image duglin/echo
```
and it returned:
```
unable to parse quantity's suffix
```
I had no idea which value it didn't like. So this PR makes it so the output
is now this:
```
Error parsing "64mi": unable to parse quantity's suffix
```
Still not perfect since I still had to think way too hard to realize that it
didn't like the lower-case `m`, but that's a different issue.
Signed-off-by: Doug Davis <dug@us.ibm.com>
* Add support for envFrom, volumeMounts, serviceAccountName, and imagePullPolicy
* Add comments for added functions
* Add test functions for --env-from
* Add test functions for --volume-mount
* Add test functions for --service-account-name and --image-pull-policy
* Add testing functions to cover the case "service update --env-from"
* Add test functions to cover the case "service update --volume-mount"
* Add missing test functions for config_changes.go
* Add testing functions for pkg/util/parsing_helper.go
* Fix a bug on a test case, caused by ignoring random orderedness of map
* Remove image-pull-policy because it is not supported by Knative
* Fix comments to clarify it as well as to fix a typo
* Remove service-account-name flags in order to submit it as a seperate PR
* Split --volume-mount flag into --volume-mount and --volume flags in order to enable multiple times mounting for the same volume
* Change the name of local variable to simplify
* Update docs
* Change the flag "--volume-mount" into "--mount", and fix it to make volume automatically when the config-map or secret is directley used. In addition, the test cases are changed to new unit test style. To keep the original orderedness given via flags, OrderedMap implementation is added as well
* Fix usage descriptions for the mount flag
* Factor out the name existence checking from createEnvFromSource
* Fix the usage description for --mount
* Sanitize a generated volume name
* Revision describe rebaseable
* Fix up for rebase
* Some tests
* moretests
* Forgot part of the refactor!
* Fix unit tests
* Change e2e tests and respond to feedback
* Adds zsh completion
- Adds back zsh completion after vendoring cobra library with a fix
- Updates the command definition to accept argument either of ['bash', 'zsh']
- Moves the completion command definition under `pkg/kn/commands/completion`
- Updates docs
- Updates CHANGELOG.adoc
* fix(golint): exported function should have comment
* Fixes PR number in CHANGELOG.adoc
* Updates unit tests
* Updates spf13/cobra dep to v0.0.5
Fixes#426
- and a couple of patches on top which aren't merged yet
- spf13/cobra#884
- spf13/cobra#899
- also updates viper to 1.4.0
* Updates to go.sum
* Updates go.mod
as a result of `go install golang.org/x/tools/cmd/goimports`
* Vendors serving v0.9.0
* Updates references per serving v0.9.0 vendoring
- Updates code and tests to refer the required data structure and method/function calls
- duckv1beta1 -> duckv1 conditions
- traffic percent value is now *int64
- containerConcurrency validation method relocation
* fix(golint): exported function should have comment
for NonReadyConditionReason function
* Updates check for removing null targets
fixes the pointer value check
* Updates per review comments
* fix(version): Displays supported APIs and version
Fixes#404
```
./kn version
Version: v20191017-local-6328a73-dirty
Build Date: 2019-10-17 09:55:55
Git Revision: 6328a73
Supported APIs:
- serving.knative.dev/v1alpha1 (knative-serving v0.8.0)
```
* Removes ServingVersion feeding from ldflags
- hardcodes the supported APIs as they're supposed to be updated when we bump deps
* Fixes typo in e2e tests
* Uses array for deterministic order of printing supported APIs
* fix(e2e): Improves the error message upon mismatch of traffic targets
Fixes#434
- The error message now prints the expected/actual length of traffic targets
- Also prints the actual traffic targets
* Fixes Golint errors
Golint errors: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...).
Martin Gencur